Bug 633169

I assume the localization team will provide a patch for this?  Conditional NAK.

Since RHEL 6.1 External Beta has begun, and this bug remains 
unresolved, it has been rejected as it is not proposed as an 
exception or blocker.

Red Hat invites you to ask your support representative to 
propose this request, if appropriate and relevant, in the 
next release of Red Hat Enterprise Linux.

Ankit, would you mind to look on this one too, please?

(In reply to comment #4)
> Ankit, would you mind to look on this one too, please?

Passing it to Leah, who takes care of zh_CN localization.

Leah, could you please look into this issue and get it fixed.

Thanks,
Ankit

fixed the translation in v6.5

Translation updates applied to evolution-2.32.3-16.el6

Verified it's NOT fixed on build evolution-2.32.3-30.el6 with latest rhel6.5 build.

Please see the attached screenshot.

Moving to ASSIGNED.

Also reproduced on zh_TW.

Created attachment 816978 [details]
Not Fixed on zh_CN and zh_TW

Created attachment 822802 [details]
Evolution translation updates

I have already sent (on 3rd September) this translation updates to Milan who applied it to evolution-2.32.3-16.el6 as per comment #8 and I have verified the changes as well. Not sure how the update got removed from latest built (that's evolution-2.32.3-30.el6)!

For the record I have attached translation updates here now.

Thanks,
Ankit

Ouch, this is embarrassing, I updated translations on Wed Aug 14 2013 at version 2.32.3-18.el6, which I committed as related to bug #630314 and this bug.

There was also another update of translations at version 2.32.3-20, which covered only bn_IN translation. It was for bug #996109.

Finally, version 2.32.3-24 adds translation update for newly added string from another evolution patch (I committed it as related to general rebase bug #883010.

There were no other translation changes otherwise. I might accidentally drop something what I didn't want to. I'm sorry for that.

(In reply to Ankit Patel from comment #18)
> Created attachment 822802 [details]
> Evolution translation updates

I checked content of the .po files after all patch applications and they are the same as those attached. That makes me think that something else broke.

(In reply to Lijun Li from comment #14)
> Created attachment 816978 [details]
> Not Fixed on zh_CN and zh_TW

From the code, the highlighted text
   "On ${AbbrevWeekdayName}, ${Year}-${Month}-${Day} at ${24Hour}:${Minute} "
   "${TimeZone}, ${Sender} wrote:"

is translated as:
   "在 ${Year}-${Month}-${Day}${AbbrevWeekdayName}的 ${24Hour}:${Minute} "
   "${TimeZone}，${Sender}写道："

which looks like the red-squared word belongs to "${AbbrevWeekdayName}". This is not taken from evolution, but is translated to '%a' and passed to strftime, which returns localized value. It is in zh_CN/zh_TW:
   Mon 一
   Tue 二
   Wed 三
   Thu 四
   Fri 五
   Sat 六
   Sun 日

So from the screenshot I suppose the message which was replied to was composed on Monday. That means that the localizations work as expected, only the string itself in these two languages might not be the right one, as expected by you?

(In reply to Milan Crha from comment #21)
> (In reply to Lijun Li from comment #14)
> > Created attachment 816978 [details]
> > Not Fixed on zh_CN and zh_TW
> 
> From the code, the highlighted text
>    "On ${AbbrevWeekdayName}, ${Year}-${Month}-${Day} at ${24Hour}:${Minute} "
>    "${TimeZone}, ${Sender} wrote:"
> 
> is translated as:
>    "在 ${Year}-${Month}-${Day}${AbbrevWeekdayName}的 ${24Hour}:${Minute} "
>    "${TimeZone}，${Sender}写道："
> 
> which looks like the red-squared word belongs to "${AbbrevWeekdayName}".
> This is not taken from evolution, but is translated to '%a' and passed to
> strftime, which returns localized value. It is in zh_CN/zh_TW:
>    Mon 一
>    Tue 二
>    Wed 三
>    Thu 四
>    Fri 五
>    Sat 六
>    Sun 日
> 
> So from the screenshot I suppose the message which was replied to was
> composed on Monday. That means that the localizations work as expected, only
> the string itself in these two languages might not be the right one, as
> expected by you?
Yes, the righ translation should be like this '星期一， 星期二，... '.

(In reply to Lijun Li from comment #22)
> (In reply to Milan Crha from comment #21)
> > is translated as:
> >    "在 ${Year}-${Month}-${Day}${AbbrevWeekdayName}的 ${24Hour}:${Minute} "
> >    "${TimeZone}，${Sender}写道："
> > ...
>
> Yes, the righ translation should be like this '星期一， 星期二，... '.

Okay. I know this is for translators, though I'm wondering what the right translation should look like in the .po file, simply by changing the above quoted two-line text.

(In reply to Milan Crha from comment #23)
> (In reply to Lijun Li from comment #22)
> > (In reply to Milan Crha from comment #21)
> > > is translated as:
> > >    "在 ${Year}-${Month}-${Day}${AbbrevWeekdayName}的 ${24Hour}:${Minute} "
> > >    "${TimeZone}，${Sender}写道："
> > > ...
> >
> > Yes, the righ translation should be like this '星期一， 星期二，... '.
> 
> Okay. I know this is for translators, though I'm wondering what the right
> translation should look like in the .po file, simply by changing the above
> quoted two-line text.

Milan
Yes, correct. it should read '星期一,星期二,星期三,星期四,星期五,星期六,星期日'.
Could you mind to apply them on your side?

I'm sorry, I'm still confused. The glibc library returns only values as noted in comment #21. Which is basically only the last "character" from the "three-characters-long strings" from the comment #26. It seems to me that the preceding two "characters" are the same for all 7 days.

The question is (and what I'm confused with):
* is it the glibc, whose translation should be changed to not return one
  "character" long string, but those "three-characters-long" strings instead,
* or it's the evolution, whose translation of
   "在 ${Year}-${Month}-${Day}${AbbrevWeekdayName}的 ..."
  is not correct and it should rather read:
   "在 ${Year}-${Month}-${Day}星期${AbbrevWeekdayName}的 ..."
?

Loking into RHEL7 translation file, the strings look the same as in RHEL6 for zh_CN. The zh_TW translation is slightly different, it reads:
   "於 ${AbbrevWeekdayName}，${Year}-${Month}-${Day} 於 ${24Hour}:${Minute}..."

Event the current upstream translation in zh_CN looks the same as in the both RHEL-s.

Peng Wu, can you please help to answer Milan's question?

It seems reproducible on Fedora 23.

CC Tommy He. any comments?

(In reply to Peng Wu from comment #29)
> It seems reproducible on Fedora 23.

The question wasn't whether it's reproducible in the current Fedora, the question is what is correct. See comment #27, please.

Maybe we can use "${WeekdayName}" instead of "${AbbrevWeekdayName}",
like:

"在 ${Year}-${Month}-${Day}${WeekdayName}的 ${24Hour}:${Minute} "
   "${TimeZone}，${Sender}写道："

Sure. If it's it, then I'll create the patch for this.

You can try yourself too, it's in GSettings, org.gnome.evolution.mail, key composer-message-attribution, which is empty by default, to use the value from the current translation.

I tried on RHEL 6.7, it seems work.

I used msgunfmt/msgfmt tool to update translation manually.

$msgunfmt /usr/share/locale/zh_CN/LC_MESSAGES/evolution-2.32.mo > evolution.po

edit file evolution.po

$msgfmt evolution.po
$sudo cp messages.mo /usr/share/locale/zh_CN/LC_MESSAGES/evolution-2.32.mo

Okay, nice. What was your final change in the translation file then, please?

I used "${WeekdayName}" instead of "${AbbrevWeekdayName}" for Chinese translation.

See comment #32.

Thanks. I changed it upstream [1] for 3.19.3+. It can be easily backported to any RHEL.

[1] https://git.gnome.org/browse/evolution/commit/?id=fd8ee34

I committed the backported upstream fix into the sources for
the evolution-2.32.3-35.el6.

Hi Tomas

Sure, we will verify it from erratum itself an provide the test result. Thanks for providing the Fixed in Version information really!

Regards
Satya

(In reply to Satyabrata Maitra from comment #49)
> Hi Tomas
> 
> Sure, we will verify it from erratum itself an provide the test result.
> Thanks for providing the Fixed in Version information really!
> 
> Regards
> Satya

Satya,

any progress here?

Thanks
-Tom

Hi Tomas

Sandeep Shedmake is working on this bug, and he will verify this bug in a short while. Sorry, I was on leave for few days.

Regards
Satya

Created attachment 1134492 [details]
Screenshot (with evolution-2.32.3-36.el6) showing full weekday name in the reply credits line for zh_CN/zh_TW

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0927.html