Bug 633435
| Summary: | /var/log/lastlog and /var/log/faillog included in cache.tar.gz | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Nico Kadel-Garcia <nkadel> |
| Component: | mock | Assignee: | Clark Williams <williams> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | el5 | CC: | dcantrell, herrold, mebrown, nkadel, williams |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | mock-1.1.10-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-23 04:57:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Setting priority as "low". This isn't critical, merely helpful in systems with low disk space for /var/cache/mock/. Nico, Take a look at: https://bugzilla.redhat.com/show_bug.cgi?id=585973 I think that the proposed patch there will do what you want (it essentially truncates lastlog|faillog to zero size before creating the cache tarball). Eeeewww. Manipulating these files to zero them this way raises interesting questions of what running tools inside the mock "chroot" cage will do. Why bother when you can simply exclude them from the tarball? well, this is long before the directory is used as a chroot. We're not running under a chroot(2) but creating the template for use in creating a chroot directory. It looks like some packages depend on the existance of faillog and lastlog, so I tend to lean towards creating empty files in the tarball. Queued for next release mock-1.1.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.5-1.fc14 mock-1.1.5-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.5-1.fc13 mock-1.0.12-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/mock-1.0.12-1.fc12 mock-1.0.12-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.12-1.el5 mock-1.0.12-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/mock-1.0.12-1.el5 mock-1.1.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. mock-1.0.13-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.13-1.el5 mock-1.0.13-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/mock-1.0.13-1.fc12 mock-1.0.14-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.14-1.el5 mock-1.0.15-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.15-1.el5 mock-1.1.9-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.9-1.fc13 mock-1.0.16-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.16-1.el5 mock-1.1.9-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.9-1.el6 mock-1.1.9-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.9-1.fc14 mock-1.1.9-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.9-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc15 mock-1.1.10-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc14 mock-1.0.17-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.17-1.el5 mock-1.1.10-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc13 mock-1.1.10-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.10-1.el6 mock-1.1.10-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. mock-1.0.17-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Unnecessary and oversized /var/log/lastlog and /var/log/faillog are included in cache.tar.gz when building mock cache. This tremendously slows cache rebuilding process and takes unnecessary cache space on systems with large uid values. Version-Release number of selected component (if applicable): 1.1.4 How reproducible: Rebuild any SRPM with mock, Steps to Reproduce: 1. mock any-package.src.rpm -r epel-5-i386 2. tar tpzvf /var/cache/mock/epel-5-i386/root_cache/root.tar.gz | grep /var/log/ Actual results: Huge ./var/log/faillog and ./var/log/lastlog files are in tarball. Expected results: Only yum.log should have anything in it. Additional info: This is easily avoided by adding following exclusions to /usr/lib/python2.4/site-packages/mock/plugins/root_cache.py: --- /usr/lib/python2.4/site-packages/mock/plugins/root_cache.py.default 2010-08-27 10:55:34.000000000 -0400 +++ /usr/lib/python2.4/site-packages/mock/plugins/root_cache.py 2010-09-13 14:34:14.000000000 -0400 @@ -120,6 +120,8 @@ "--exclude=./dev", "--exclude=./tmp/ccache", "--exclude=./var/cache/yum", + "--exclude=./var/log/lastlog", + "--exclude=./var/log/faillog", "."], shell=False )