Bug 633983

Summary:	Luci does not handle parameter "nodename" related to fence_scsi fence agent correctly
Product:	Red Hat Enterprise Linux 6	Reporter:	Jan Pokorný [poki] <jpokorny>
Component:	luci	Assignee:	Ryan McCabe <rmccabe>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0	CC:	bbrock, cluster-maint, rmusil
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	luci-0.23.0-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:56:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2010-09-14 20:13:31 UTC

Description of problem:
In connection with bug #633567, it was discovered that Luci currently treats "nodename" parameter for fence_scsi fence agent as "global" per its device instance (i.e. it is by "fencedevice" xml-node in cluster.conf), instead of node-local one (i.e. by "device" xml-node).

In addition, there are two related problems that should be fixed as well:

A. on RHEL5(4), this parameter served cluster for specific reason and it was expected (and as I verified, this rule had no exception) that its value is the same as the name of the respective node ("clusternode" xml-node, attribute "name"), see http://sources.redhat.com/cluster/wiki/SCSI_FencingConfig_RHEL5
- Luci currently handles this parameter as user-configurable, which can lead to problems when the stated rule is broken -> this logic should be applied automatically in silence without giving user a chance to modify it in Luci

B. for RHEL6-based cluster, setting "nodename" parameter can be omitted, because in this case (and only in this case!), mentioned rule is applied implicitly by the logic of fence components (fenced)
- to keep cluster.conf as "clean" as possible, it would be a good idea to choose omitting this parameter (note: once "nodename" parameter present by "device" xml-node under "fence" - "method" section, it ought to be present also by "device" xml-node under "unfence" section for particular node)

Comment 3 Jan Pokorný [poki] 2010-09-15 21:33:18 UTC

This should be fixed as of http://git.fedorahosted.org/git/?p=luci.git;a=commit;h=51c43365b959ca2ac8e4356575713e41e13c8484

Comment 10 Brian Brock 2011-02-24 19:34:25 UTC

fix verified in luci-0.23.0-4

the <fencedevice> name parameter is set during element creation, and matches the <fence><method><device name=""> parameter selected from a drop-down list.

Comment 11 errata-xmlrpc 2011-05-19 13:56:25 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0655.html