Bug 634052 (ghc-ConfigFile)

Updated to cabal-0.22.4:

Spec: http://petersen.fedorapeople.org/ghc-ConfigFile/ghc-ConfigFile.spec
SRPM: http://petersen.fedorapeople.org/ghc-ConfigFile/ghc-ConfigFile-1.0.6-3.fc14.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2747651

Scratch build against new hslogger-1.1.3:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2756293

[+]MUST: rpmlint must be run on every package. The output should be posted in the review.
ghc-ConfigFile.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile.i686: W: spelling-error %description -l en_US parsable -> parable, parables, passable
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile.src: W: spelling-error %description -l en_US parsable -> parable, parables, passable
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile-devel.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile-devel.i686: W: spelling-error %description -l en_US parsable -> parable, parables, passable
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile-prof.i686: E: devel-dependency ghc-ConfigFile-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-ConfigFile-prof.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile-prof.i686: W: spelling-error %description -l en_US parsable -> parable, parables, passable
The value of this tag appears to be misspelled. Please double-check.

ghc-ConfigFile-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-ConfigFile-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/ConfigFile-1.0.6/libHSConfigFile-1.0.6_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

4 packages and 1 specfiles checked; 1 errors, 10 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK, LGPL v2+
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK , cabal2spec 0.22.4
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Buildroot is ignored - OK not present
        %clean is ignored -  OK not present
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK,in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
License is LGPL v2
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
COPYING contains the license text and is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum ConfigFile-1.0.6.tar.gz 
fbdef31a2989723cc25ba92622ff0e42  ConfigFile-1.0.6.tar.gz

md5sum ghc-ConfigFile-1.0.6-3.fc14.src/ConfigFile-1.0.6.tar.gz 
fbdef31a2989723cc25ba92622ff0e42  ghc-ConfigFile-1.0.6-3.fc14.src/ConfigFile-1.0.6.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on i686
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
Consider putting sparcv9 in ExclusiveArch
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
API documentation in devel package
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-ConfigFile 
error: Failed dependencies:
        ghc(ConfigFile-1.0.6) = b5d605501ddab7064102a00014d341fe is needed by (installed) ghc-ConfigFile-devel-1.0.6-3.fc15.x86_64
        ghc-ConfigFile = 1.0.6-3.fc15 is needed by (installed) ghc-ConfigFile-devel-1.0.6-3.fc15.x86_64

rpm -e ghc-ConfigFile -devel
error: Failed dependencies:
        ghc(ConfigFile-1.0.6) = b5d605501ddab7064102a00014d341fe is needed by (installed) ghc-ConfigFile-devel-1.0.6-3.fc15.x86_64
        ghc-ConfigFile = 1.0.6-3.fc15 is needed by (installed) ghc-ConfigFile-devel-1.0.6-3.fc15.x86_64

[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
Checked with rpmquery --list
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installs fine. Imported Data.ConfigFile.Parser into ghci. Works fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

APPROVED.

Can sparcv9 be added to the Exclusive Arch field while generating template spec file by cabal2spec?

(In reply to comment #4)
> Can sparcv9 be added to the Exclusive Arch field while generating template spec
> file by cabal2spec?

Yes, planning a cabal2spec update soon... should have done it already.

Thank for the review.

New Package SCM Request
=======================
Package Name: ghc-ConfigFile
Short Description: configuration file library for Haskell
Owners: petersen
Branches: f13 f14 f15
InitialCC: haskell-sig

Git done (by process-git-requests).

Built for rawhide and now for f13, f14, f15.

ghc-ConfigFile-1.0.6-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ghc-ConfigFile-1.0.6-4.fc15

ghc-ConfigFile-1.0.6-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ghc-ConfigFile-1.0.6-4.fc14

ghc-ConfigFile-1.0.6-4.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/ghc-ConfigFile-1.0.6-4.fc13

ghc-ConfigFile-1.0.6-4.fc15 has been pushed to the Fedora 15 stable repository.

ghc-ConfigFile-1.0.6-4.fc14 has been pushed to the Fedora 14 stable repository.

ghc-ConfigFile-1.0.6-4.fc13 has been pushed to the Fedora 13 stable repository.