Bug 634375
Summary: | tomcatjss rpm depends on tomcat5 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Dogtag Certificate System | Reporter: | John Dennis <jdennis> | ||||
Component: | Tomcatjss | Assignee: | RHCS Maintainers <rhcs-maint> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Ben Levenson <benl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | high | ||||||
Version: | unspecified | CC: | ascheel, cfu, dpal, jdennis, jgalipea, mharmsen | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2019-07-23 14:10:45 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 541012, 658188 | ||||||
Attachments: |
|
Description
John Dennis
2010-09-15 23:22:14 UTC
Created attachment 464602 [details]
Build tomcatjss against tomcat6
This removes the references to tomcat 5 and tomcat 5 jars. The jars needed for building were updated to point to tomcat 6 locations. A new method was added as a stub to permit building, please the comment in the code for an explanation.
Unfortunately the conclusion in comment #1 was not accurate. There was a change in the tomcat API (albeit minor, see comment in patch). That does make tomcatjss dependent on the tomcat version. I'm not entirely sure how to handle the dependency on tomcat versions with tomcatjss. If one follows the existing model it would suggest there should be a tomcatjss5 package and a tomcatjss6 package, etc. But providing new packages and deprecating old packages is a disruptive process, especially for RHEL. I'm not sure it's really warranted in this case, although independent packages based on the tomcat version is probably technically correct. Now that we've switched over to tomcat 6, we should be building tomcatjss against tomcat 6. New dogtag/cs packages based on tomcat 6 will be built and should require this new version of tomcatjss built against tomcat 6. Please note, the spec file was not updated in the patch to bump it's version and release information, that should be done, once done the other dogtag spec files should require a version of tomcatjss built against tomcat 6. Comment on attachment 464602 [details]
Build tomcatjss against tomcat6
Also, since version 2.0.0 of tomcatjss has never been built/released in either Koji or Brew (and the existing changelog comment is tied too closely to Dogtag):
Change:
%changelog
* Tue Aug 10 2010 Matthew Harmsen <mharmsen> 2.0.0-1
- Updated Dogtag 1.3.x --> Dogtag 2.0.0.
To:
%changelog
* Tue Dec 14 2010 John Dennis <jdennis>
- Updated 'tomcatjss' to utilize 'tomcat6'.
Sending build.xml Sending src/org/apache/tomcat/util/net/jss/JSSImplementation.java Sending tomcatjss.spec Transmitting file data ... Committed revision 106. Re-opening this bug, as tomcatjss 2.0.0 must still be built on the following platforms: * Fedora 13 (fc13) * Fedora 14 (fc14) * Fedora 15 (fc15) * RHEL 5 EPEL (el5) * RHEL 5 (el5idm) * RHEL 6 (el6) Re-assigning this to kwright. Correction --- do NOT build tomcatjss 2.0.0 on RHEL 5 (el5idm), as RHCS 8.1 still relies upon tomcat5. |