Bug 634438

Summary: some pynfs failures need to investigate more if they're actual bug
Product: Red Hat Enterprise Linux 6 Reporter: yanfu,wang <yanwang>
Component: kernelAssignee: J. Bruce Fields <bfields>
Status: CLOSED DUPLICATE QA Contact: yanfu,wang <yanwang>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: bfields, rwheeler
Target Milestone: rcKeywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-01 15:45:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
the full failure log
none
return expired instead of bad on stateid's we can't find none

Description yanfu,wang 2010-09-16 03:38:06 UTC 
Created attachment 447616 [details]
the full failure log

Run pynfs on RHEL6-RC3 on i386 and x86_64 using http://fedoraproject.org/wiki/QA:Testcase_nfs_pynfs. There're some extra failures occur on which
didn't included in the known faiure list.

CLOSE8   st_close.testTimedoutClose1                              :
FAILURE
           CLOSE after lease timeout should return
           NFS4ERR_EXPIRED, instead got NFS4ERR_BAD_STATEID

CLOSE9   st_close.testTimedoutClose2                              :
FAILURE
           CLOSE after lease timeout with lock held should return
           NFS4ERR_EXPIRED, instead got NFS4ERR_BAD_STATEID

LKU10    st_locku.testTimedoutUnlock                              :
FAILURE
           Try to unlock file after timed out should return
           NFS4ERR_EXPIRED or NFS4_OK, instead got
           NFS4ERR_BAD_STATEID

RPLY8    st_replay.testUnlockWait                                 :
FAILURE
           Call to be replayed should return NFS4_OK or
           NFS4ERR_EXPIRED, instead got NFS4ERR_BAD_STATEID

RPLY10   st_replay.testCloseWait                                  :
FAILURE
           Call to be replayed should return NFS4_OK or
           NFS4ERR_EXPIRED, instead got NFS4ERR_BAD_STATEID
Comment 1 RHEL Program Management 2010-09-16 03:58:01 UTC 
Thank you for your bug report. This issue was evaluated for inclusion
in the current release of Red Hat Enterprise Linux. Unfortunately, we
are unable to address this request in the current release. Because we
are in the final stage of Red Hat Enterprise Linux 6 development, only
significant, release-blocking issues involving serious regressions and
data corruption can be considered.

If you believe this issue meets the release blocking criteria as
defined and communicated to you by your Red Hat Support representative,
please ask your representative to file this issue as a blocker for the
current release. Otherwise, ask that it be evaluated for inclusion in
the next minor release of Red Hat Enterprise Linux.
Comment 2 J. Bruce Fields 2010-10-11 22:56:46 UTC 
Created attachment 452816 [details]
return expired instead of bad on stateid's we can't find

This fixes the above failures.  (It also causes failures in RD9 and WRT10, but I don't think those failures are a problem.)

A client that receives BAD_STATEID when it should have received EXPIRED_STATEID may fail when it would have been able to recover.  So without this patch a client may fail to recover correctly after a network partition that causes its state to expire.
Comment 3 yanfu,wang 2010-10-14 06:49:03 UTC 
I patched the rhel6-rc-4 kernel and verified it, the result as your said, these failures on comment #0 are gone, so I think the fixes is fine to me.
Comment 5 RHEL Program Management 2011-01-07 04:46:47 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 6 yanfu,wang 2011-01-07 06:10:21 UTC 
(In reply to comment #5)
> This request was evaluated by Red Hat Product Management for
> inclusion in the current release of Red Hat Enterprise Linux.
> Because the affected component is not scheduled to be updated
> in the current release, Red Hat is unfortunately unable to
> address this request at this time. Red Hat invites you to

What's the meaning of "the affected component is not scheduled to be updated
in the current release"? kernel will not update in rhel6.1?

> ask your support representative to propose this request, if
> appropriate and relevant, in the next release of Red Hat
> Enterprise Linux. If you would like it considered as an
> exception in the current release, please ask your support
> representative.
Comment 7 Suzanne Logcher 2011-01-07 16:07:33 UTC 
This request was erroneously denied for the current release of Red Hat
Enterprise Linux.  The error has been fixed and this request has been
re-proposed for the current release.
Comment 8 yanfu,wang 2011-01-11 07:35:38 UTC 
according to above comment, I re-open the bug if the bug will fix in rhel6.1.
Comment 9 RHEL Program Management 2011-02-01 05:39:27 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 10 Ric Wheeler 2011-02-01 11:37:35 UTC 
I think that per comment https://bugzilla.redhat.com/show_bug.cgi?id=634438#c8 this issue is fixed in 6.1.

Not sure what happened with the BZ flags that let it fall off, but reopening with qa & dev acks both set.

Thanks!
Comment 11 RHEL Program Management 2011-02-01 11:50:52 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 12 J. Bruce Fields 2011-02-01 15:45:29 UTC 
The patch was incorporated in the set of patches merged as part of bz 653068; assuming, therefore, that the correct resolution is to close this as a duplicate of that bug.

*** This bug has been marked as a duplicate of bug 653068 ***