Bug 634608
| Summary: | Review Request: rubygem-ruby-ole - Ruby OLE library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Stahnke <mastahnke> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-ruby-ole-1.2.11.1-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-29 17:17:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Stahnke
2010-09-16 14:13:56 UTC
I will take this one. Instead would you review my another review request bug 635126 (submitted just now)? Well, I don't see any files which indicates the license of this gem. Would you ask the upstream? On bug 633549: --- Comment #6 from Michael Stahnke <mastahnke> 2010-09-22 10:13:19 JST --- According to http://code.google.com/p/ruby-ole/ it is GPLv2. Should I file a bug with upstream to include that in the file package? At least please contact the upstream to verify the actual license (well, as I have seen not a few cases where the information on the upstream URL is outdated, I usually don't want to trust the information on the upstream URL and want to check what is actually written in the source tarball) Issue submitted upstream. http://code.google.com/p/ruby-ole/issues/detail?id=6 Response from Upstream: Comment #1 on issue 6 by aquasync: Unable to package for Linux distro due to missing License file or specification in source code files http://code.google.com/p/ruby-ole/issues/detail?id=6 Hi, the project been re-licenced as MIT, and a COPYING file added. Released as 1.2.11. ---------- I will update package and post here shortly. http://stahnma.fedorapeople.org/reviews/rubygem-ruby-ole-1.2.11.1-1.fc15.src.rpm http://stahnma.fedorapeople.org/reviews/rubygem-ruby-ole.spec Okay.
* Unused macro
- Defined macro %ruby_sitelib is used nowhere
* BuildRoot
- BuildRoot line is no longer used on Fedora and EPEL6.
Not blockers
----------------------------------------------------
This package (rubygem-ruby-ole) is APPROVED
by mtasaka
----------------------------------------------------
I'll remove the sitelib for sure. The BuildRoot stuff I leave in because I spend a lot of time in EPEL5 and I don't think it hurts anything. New Package SCM Request ======================= Package Name: rubygem-ruby-ole Short Description: Ruby OLE library Owners: stahnma Branches: EL5 EL6 F13 F14 F15 InitialCC: Git done (by process-git-requests). We are not yet doing f15 branches. rubygem-ruby-ole-1.2.11.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-ruby-ole-1.2.11.1-1.fc14 rubygem-ruby-ole-1.2.11.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-ruby-ole-1.2.11.1-1.fc13 http://lists.fedoraproject.org/pipermail/scm-commits/2010-October/513410.html Maybe this suggests some incompatibility of ruby-ole with ruby 1.8.5? If so maybe applying some patch on EL-5 is needed. It does, it's a DateTime representation issue. Basically the tests expect the format Z for the timezone when the actual output is +00:00:00. It's something I have seen in several gems working with 1.8.5 vs. 1.8.6. I believe either rubinus or rcov has this same issue. My plan was to play with it in epel-testing and ensure I could do everything I needed to there. I have no plans to push to stable until I am certain functionality is correct. I can patch out the failure in the tests easily. I'm just not certain that's the right thing to do yet. I was looking for information in how Datetime vs Date vs Time was handled in 1.8.5 vs 1.8.6. Basically the patch is something like this. + #assert_equal '2007-01-01T00:00:00+00:00', time.to_s + assert_equal '2007-01-01T00:00:00Z', time.to_s rubygem-ruby-ole-1.2.11.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-ruby-ole'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-ruby-ole-1.2.11.1-1.fc13 Closing. rubygem-ruby-ole-1.2.11.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-ruby-ole-1.2.11.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |