Bug 635654
Summary: | Review Request: perl-Text-Hunspell - Perl interface to the Hunspell library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-11-13 08:46:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 636763 | ||
Bug Blocks: |
Description
Paul Howarth
2010-09-20 13:04:45 UTC
Review: + package builds in koji (f15). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2478975 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) ce21d98e2ba4d2de0bf54cb56fcaee0982830c0d Text-Hunspell-2.01.tar.gz ce21d98e2ba4d2de0bf54cb56fcaee0982830c0d Text-Hunspell-2.01.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + Macro use appears rather consistent. + Package contains code, not content. + no -devel subpackage + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=16, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.22 cusr 0.05 csys = 0.31 CPU) + Not a GUI application Suggestions 1) If there are no plans to add this package < F13 releases then please a) remove buildroot b) remove cleaning of buildroot in %install c) remove %clean section 2) Is versioned BR: needed in this package? hunspell-devel >= 1.2.8 If not then please remove it. APPROVED. (In reply to comment #1) > Suggestions > 1) If there are no plans to add this package < F13 releases then please > a) remove buildroot > b) remove cleaning of buildroot in %install > c) remove %clean section I plan to build it for F-12. These items can be removed once it goes EOL. > 2) Is versioned BR: needed in this package? > hunspell-devel >= 1.2.8 > If not then please remove it. The package won't work with earlier versions of hunspell. Adding the versioned dependency makes it clear that the package won't work with (say) EPEL 4 and 5. Thanks for the review Parag. New Package SCM Request ======================= Package Name: perl-Text-Hunspell Short Description: Perl interface to the Hunspell library Owners: pghmcfc Branches: f12 f13 f14 el6 Forgot the InitialCC: New Package SCM Request ======================= Package Name: perl-Text-Hunspell Short Description: Perl interface to the Hunspell library Owners: pghmcfc InitialCC: perl-sig Branches: f12 f13 f14 el6 Git done (by process-git-requests). perl-Text-Hunspell-2.01-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Text-Hunspell-2.01-2.fc13 perl-Text-Hunspell-2.01-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Text-Hunspell-2.01-2.fc14 perl-Text-Hunspell-2.01-2.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/perl-Text-Hunspell-2.01-2.fc12 All branches built except for EL-6 - the EL-6 buildroot doesn't contain any EL-6 Workstation-only packages and one of those (hunspell-en) is needed for this package. perl-Text-Hunspell-2.01-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Text-Hunspell-2.01-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-Text-Hunspell-2.01-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Everything's built and pushed to stable now except the EL-6 version (see Bug #636763), which probably won't be resolved until RHEL-6 GA. Can this be closed then? I was going to wait until RHEL 6 GA when I could build the EPEL-6 version, but if you'd like it off your list of active tickets, feel free to close it. Now built for EL-6; closing. |