Bug 635788
Summary: | Review Request: nautilus-terminal - Terminal embedded in Nautilus | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hicham HAOUARI <hicham.haouari> |
Component: | Package Review | Assignee: | Arun S A G <sagarun> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | elad, fedora-package-review, jgorig, kalevlember, notting, sagarun |
Target Milestone: | --- | Flags: | sagarun:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | nautilus-terminal-0.7-1.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-10-12 03:09:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hicham HAOUARI
2010-09-20 17:40:07 UTC
Package build fails on x86_64. Files are installed into /usr/lib but %{_libdir} macro is used in %files. This should be consistent. Fixed. F-12 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2481458 F-13 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2481459 F-14 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2481460 F-15 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2481461 ************************************************************* rpmlint nautilus-terminal-0.6-1.fc13.i686.rpm nautilus-terminal.i686: E: no-binary nautilus-terminal.i686: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. ************************************************************* Ideally this package should be installed in /usr/share and be noarch, but nautilus doesn't load its extensions from there. New upstream release SPEC URL : http://hicham.fedorapeople.org/nautilus-terminal/nautilus-terminal.spec SRPM URL : http://hicham.fedorapeople.org/nautilus-terminal/nautilus-terminal-0.7-1.fc13.src.rpm Description: Nautilus Terminal is a terminal embedded in Nautilus, the GNOME's file browser. It is always open in the current folder, and follows the navigation (like an automated "cd" command). i will do an unofficial review. + = OK - = NA ? = issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistent macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. Couldn't check on koji becuase i was unable to login because of an SSL error. it compiles on my machine. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. Seems that everything is OK with your package. I will do the review. complete review: + = OK - = NA ? = issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [zer0c00l@gnubox SPECS]$ md5sum nautilus-terminal_0.7_src.tar.gz 68cecfb4cfb818a1dd0ffed759e7122d nautilus-terminal_0.7_src.tar.gz [zer0c00l@gnubox SPECS]$ md5sum ~/rpmbuild/SOURCES/nautilus-terminal_0.7_src.tar.gz 68cecfb4cfb818a1dd0ffed759e7122d /home/zer0c00l/rpmbuild/SOURCES/nautilus-terminal_0.7_src.tar.gz - Package needs ExcludeArch + BuildRequires correct + Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. http://koji.fedoraproject.org/koji/taskinfo?taskID=2497104 + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: + Should build in mock. + Should build on all supported archs + Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) rpmlint output: --------------------- [zer0c00l@gnubox nautilus-terminal-0.7]$ rpmlint ~/rpmbuild/RPMS/i686/nautilus-terminal-0.7-1.fc13.i686.rpm nautilus-terminal.i686: E: no-binary nautilus-terminal.i686: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. This is not an issue.Looks good to me. XXXXXXXXXX APPROVED XXXXXXXXXX It might be better to avoid using %ifarch like that as it will break on other 64 bit multilib architectures. Instead of: %ifarch x86_64 ppc64 sed -i 's|/usr/lib/nautilus/extensions-2.0|/usr/lib64/nautilus/extensions-2.0|g' install.sh %endif I'd use: sed -i 's|/usr/lib/nautilus/extensions-2.0|%{_libdir}/nautilus/extensions-2.0|g' install.sh (In reply to comment #7) > It might be better to avoid using %ifarch like that as it will break on other > 64 bit multilib architectures. > Instead of: > > %ifarch x86_64 ppc64 > sed -i > 's|/usr/lib/nautilus/extensions-2.0|/usr/lib64/nautilus/extensions-2.0|g' > install.sh > %endif > > I'd use: > > sed -i > 's|/usr/lib/nautilus/extensions-2.0|%{_libdir}/nautilus/extensions-2.0|g' > install.sh Yes, I already made that locally, thanks. New Package SCM Request ======================= Package Name: nautilus-terminal Short Description: Terminal embedded in Nautilus Owners: hicham Branches: F-12 F-13 F-14 InitialCC: hicham Git done (by process-git-requests). nautilus-terminal-0.7-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nautilus-terminal-0.7-1.fc14 nautilus-terminal-0.7-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/nautilus-terminal-0.7-1.fc13 nautilus-terminal-0.7-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/nautilus-terminal-0.7-1.fc12 nautilus-terminal-0.7-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nautilus-terminal'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/nautilus-terminal-0.7-1.fc14 nautilus-terminal-0.7-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. nautilus-terminal-0.7-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. nautilus-terminal-0.7-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |