Bug 636211

Summary:	monitor-queue doesnt work and is not documented
Product:	Red Hat Satellite 5	Reporter:	Petr Sklenar <psklenar>
Component:	Monitoring	Assignee:	Jan Pazdziora (Red Hat) <jpazdziora>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jan Hutař <jhutar>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	540	CC:	cperry, jhutar, jpazdziora, ociencia
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	NPalert-1.126.15-3 perl-NOCpulse-Gritch-1.27.9-3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-09-21 09:35:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	819081

Description Petr Sklenar 2010-09-21 16:44:39 UTC

Description of problem:
I have no idea what for is monitor-queue but monitor-queue doesn't work and it is not documented.

Version-Release number of selected component (if applicable):
Satellite-5.4.0-RHEL5-re20100910.2
perl-NOCpulse-Gritch-1.27.8-1.el5sat
NPalert-1.126.15-1.el5sat

How reproducible:
always

Steps to Reproduce:
1.
# monitor-queue 
 queue size is 12 at Tue Sep 21 12:36:24 2010
Undefined subroutine &NOCpulse::Gritch::get_sendmail called at /usr/lib/perl5/vendor_perl/5.8.8/NOCpulse/Gritch.pm line 408.


# monitor-queue -help
-help queue size is 12 at Tue Sep 21 12:39:00 2010
Undefined subroutine &NOCpulse::Gritch::get_sendmail called at /usr/lib/perl5/vendor_perl/5.8.8/NOCpulse/Gritch.pm line 408.

# monitor-queue --help
--help queue size is 12 at Tue Sep 21 12:43:02 2010
Undefined subroutine &NOCpulse::Gritch::get_sendmail called at /usr/lib/perl5/vendor_perl/5.8.8/NOCpulse/Gritch.pm line 408.

# man monitor-queue
No manual entry for monitor-queue

# rpm -qf /usr/lib/perl5/vendor_perl/5.8.8/NOCpulse/Gritch.pm
perl-NOCpulse-Gritch-1.27.8-1.el5sat

rpm -qf `which monitor-queue`
NPalert-1.126.15-1.el5sat

Actual results:
perl error
no help, no usage message, no man

Expected results:
its documented.
it doesnt return perl error.

Additional info:

Comment 1 Miroslav Suchý 2010-09-27 16:42:17 UTC

Clearing Regression flag. This always been this way.

Created man page if commits 
1430a68ebeb74542801ed60047cc8fe80352dae6
5a3abbfa337d031c0af11bbb994fb9c5a007b5e4

Comment 2 Miroslav Suchý 2011-04-21 11:22:36 UTC

Cherry picked as commits
68ef362fc4d4eefc20f20a6e41f367e0932ba828
36bfb5a15e71be1d8e6877ef8b9a54d09e182fcd

Comment 6 Jan Pazdziora (Red Hat) 2012-07-27 14:10:09 UTC

What does

rpm -q /usr/share/perl5/Mail/Send.pm

print?

Comment 7 Jan Pazdziora (Red Hat) 2012-07-27 14:16:13 UTC

Could you please check if patching NOCpulse/Gritch.pm with

diff --git a/monitoring/PerlModules/NP/Gritch/Gritch.pm b/monitoring/PerlModules/NP/Gritch/Gritch.pm
index bddefbb..91cf731 100644
--- a/monitoring/PerlModules/NP/Gritch/Gritch.pm
+++ b/monitoring/PerlModules/NP/Gritch/Gritch.pm
@@ -406,7 +406,8 @@ sub sendmail {
    } else {
        # Use sendmail
        if (Mail::Mailer::is_exe('sendmail')) {
-           my $msg = Mail::Send->new(Subject => $subject, To => $recip, From => $self->recipient);
+           my $msg = Mail::Send->new(Subject => $subject, To => $recip);
+           $msg->set('From', $self->recipient);
            my $fh = $msg->open('sendmail');
            print $fh $message;
            $fh->close;

fixes the problem on your installation?

Comment 10 Jan Pazdziora (Red Hat) 2012-07-30 13:18:22 UTC

(In reply to comment #7)
> Could you please check if patching NOCpulse/Gritch.pm with
> 
> diff --git a/monitoring/PerlModules/NP/Gritch/Gritch.pm
> b/monitoring/PerlModules/NP/Gritch/Gritch.pm
> index bddefbb..91cf731 100644
> --- a/monitoring/PerlModules/NP/Gritch/Gritch.pm
> +++ b/monitoring/PerlModules/NP/Gritch/Gritch.pm
> @@ -406,7 +406,8 @@ sub sendmail {
>     } else {
>         # Use sendmail
>         if (Mail::Mailer::is_exe('sendmail')) {
> -           my $msg = Mail::Send->new(Subject => $subject, To => $recip,
> From => $self->recipient);
> +           my $msg = Mail::Send->new(Subject => $subject, To => $recip);
> +           $msg->set('From', $self->recipient);
>             my $fh = $msg->open('sendmail');
>             print $fh $message;
>             $fh->close;
> 
> fixes the problem on your installation?

Fixed in Spacewalk master, 674255758d325b1ce0cca8bff0b684371dc04bec.

Comment 17 Clifford Perry 2012-09-21 09:35:28 UTC

This issue is resolved with the release of RHN Satellite 5.5. 

As of September 20th 2012, RHN Satellite 5.5 has been generally available. 

Release Notes and other 5.5 documentation can be found here:

 https://access.redhat.com/knowledge/docs/Red_Hat_Network_Satellite/

The associated Errata for the 5.5 release are:

5.5 Satellite GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1296.html

5.5 Upgrade Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1298.html

5.5 RHN Proxy GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1297.html

5.5 RHN Tools GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1299.html

Regards,
Clifford
- Engineering Manager, Satellite