Bug 636267

Summary: UI: "Update" buttons at "Fence Devices" tab do effectively nothing.
Product: Red Hat Enterprise Linux 6 Reporter: Jan Pokorný [poki] <jpokorny>
Component: luciAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: low    
Version: 6.1CC: bbrock, cluster-maint, rmusil
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: luci-0.23.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:56:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot: how it looked before.
none
Screenshot: how it looks after the fix.
none
Visualisation of what have changed (produced with "compare" of ImageMagick suite). none

Description Jan Pokorný [poki] 2010-09-21 19:29:00 UTC
Description of problem:
Beside doing effectively nothing (or better said, these buttons do the same as "Apply" button displayed in the details to selected fence device, but they are not doing this correctly -> NOOP), when comes to semantics, there is also no serious application for these buttons -- maybe only offering the same functionality as browser's refresh/reload button, but nothing similar is currently present across Luci (this is a subject of bug #617586). Because of mentioned reasons (+ mentioned redundancy with "Apply" button), it is probably relic of early versions of code and should be removed.

Version-Release number of selected component (if applicable):
luci-0.22.2-14.el6.x86_64 (and also current upstream)

How reproducible:
Always.

Steps to Reproduce (to show that neither of these buttons work):
1. go to "Fence Devices" tab, add any fence device instance if none present
2a. select at least one fence device instance and then click on "Update" button at the top bar (the one in between Add and Delete)
2b. alternatively, display details to chosen fence device instance (by clicking its name), then click on "recycling" icon on the right (with "update" hint)
3. "No name was given for this fence device" message is displayed (otherwise NOOP action)

Additional info:
To fix is, the mentioned buttons are presumably removed. In this case, the way to test it would be to check that these two buttons (each on separate position as stated above) are away.

Comment 2 Jan Pokorný [poki] 2010-09-22 20:32:05 UTC
Created attachment 449046 [details]
Screenshot: how it looked before.

Comment 3 Jan Pokorný [poki] 2010-09-22 20:35:43 UTC
Created attachment 449048 [details]
Screenshot: how it looks after the fix.

This should be fixed in http://git.fedorahosted.org/git/?p=luci.git;a=commitdiff;h=6a765721487f2b75a92439a7f2588f37a6964bff;hp=51c43365b959ca2ac8e4356575713e41e13c8484

Find attached the appearance after the fix is applied.

Comment 4 Jan Pokorný [poki] 2010-09-22 20:40:16 UTC
Created attachment 449052 [details]
Visualisation of what have changed (produced with "compare" of ImageMagick suite).

Comment 12 errata-xmlrpc 2011-05-19 13:56:29 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0655.html