Bug 636300

Summary: Egenera fence agent: specifying username not arranged correctly
Product: Red Hat Enterprise Linux 6 Reporter: Jan Pokorný [poki] <jpokorny>
Component: luciAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: low    
Version: 6.1CC: bbrock, cluster-maint, rmusil
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: luci-0.23.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:56:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2010-09-21 20:55:13 UTC
Description of problem:
There are two subproblems:
A. username can be optionally defined twice (per device instance and per node) while this ability to define the same parameter on both places is:
  - unique across Luci (this should be presently the only such case which can be strange to the user)
  - not necessary (it does not make much sense to define it twice, although
    optionally)
(note: per-node username setting does not even work, but at least, user is offered with setting it on this place)
B. according to the code of fence_egenera, the key parameter to set username is "user", but Luci uses "username" (related problem is missing information about how to set username in fence_egenera man page, see bug #635824)

Version-Release number of selected component (if applicable):
luci-0.22.2-14.el6.x86_64

How reproducible:
Always.

Steps to Reproduce (how to input username information twice while the incorrect parameter "username" instead of "user" is used):
1. go to "Fence Devices", select Add, choose the Egenera device
2. *now you can set also username*, do it and when other fields are filled, submit the form
3. now go "Nodes" tab, click on certain node, in its details add a fencing method (if no one currently present), from within this method, click "Add a Fence Instance", here, select just added fence device instance
4. *now you can set also username*, do it (although this one will not be propagated to the cluster.conf as mentioned in description)
  
Actual results:
Username setting was shown on two different places and cluster.conf contains something like this:

(...)
        <clusternode name="node1" nodeid="1" votes="1">
                <fence>
                        <method name="test_method">
                                <device name="test_egenera"/>
                        </method>
                </fence>
        </clusternode>
(...)
<fencedevices>
        <fencedevice agent="fence_egenera" cserver="localhost" name="test_egenera" username="username_global"/>
</fencedevices>


Expected results:
Username setting was shown only at on place (presumably in per device instance configuration) and in the parameter "user" was used instead of "username", i.e. cluster.conf from above should look like this:

(...)
        <clusternode name="node1" nodeid="1" votes="1">
                <fence>
                        <method name="test_method">
                                <device name="test_egenera"/>
                        </method>
                </fence>
        </clusternode>
(...)
<fencedevices>
        <fencedevice agent="fence_egenera" cserver="localhost" name="test_egenera" user="username_global"/>
</fencedevices>


Additional info:
To verigy the fix, no Egenera hardware should be needed, checking Luci interactively and watching cluster.conf should be enough.

Comment 2 Jan Pokorný [poki] 2010-09-23 18:46:45 UTC
(In reply to comment #0)
Not so important, but the cluster.conf snippets given in a bug description cannot be generated by Luci because of mandatory "lpan" and "pserver" parameters.

Hence, I should have used:
  <device lpan="test_lpan" name="test_egenera" pserver="test_pserver"/>
instead of bare:
  <device name="test_egenera"/>

Comment 3 Jan Pokorný [poki] 2010-09-23 18:52:28 UTC
This should be fixed in http://git.fedorahosted.org/git/?p=luci.git;a=commit;h=738f497047396f1f881eafeace30f7b9d9368fd9.

Comment 11 errata-xmlrpc 2011-05-19 13:56:28 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0655.html