Bug 636714

Summary: Dashboard manual color field silently accepts bad colors
Product: [Other] RHQ Project Reporter: Corey Welton <cwelton>
Component: Core UIAssignee: John Mazzitelli <mazz>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: low Docs Contact:
Priority: low    
Version: 4.0.0CC: mazz
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 585306, 637173    

Description Corey Welton 2010-09-23 01:53:51 UTC 
Description of problem:
In Edit mode, user can enter any number of appropriate colors in the "Background" field, hit tab, and the color is changed.  However if user enters something invalid, it is accepted (and messages indicate that it is saved).

Version-Release number of selected component (if applicable):


How reproducible:
Every time.

Steps to Reproduce:
1.  Go into edit mode for a dashboard tab.
2.  in the free text field, enter the value "red" and hit tab.  Notice the color change and the message tray notice that it was successfully saved
3.  Repeat step 2 with valid hex or named colors, i.e., "limegreen", "slategray", "skyblue"
4.  Repeat again with the term "snortblatt"
  
Actual results:
Value gets saved regardless as to whether it is bogus.

Expected results:
Rejection?

Additional info:
Interestingly, navigating away from dash and back to it, the color of the dash itself is returned to something sane, white.  The bogus value remains in the field however.
Comment 1 Corey Welton 2010-09-23 01:55:19 UTC 
Also another interesting aside, multibyte chars entered into that field _do_ get rejected -- the value gets reverted back to the last known good value.
Comment 2 John Mazzitelli 2011-02-18 17:29:11 UTC 
commit 4c20f81

using new rhq color button item component. it uses less real estate than the original color picker item and it avoids allowing you to enter invalid colors.

to see this - go to edit the dashboard and see there is a new "Background" button. click it and you can select a color.
Comment 3 Corey Welton 2011-03-02 21:51:52 UTC 
Verified.
Comment 4 Corey Welton 2011-05-24 01:16:39 UTC 
Bookkeeping - closing bug - fixed in recent release.
Comment 5 Corey Welton 2011-05-24 01:16:44 UTC 
Bookkeeping - closing bug - fixed in recent release.
Comment 6 Corey Welton 2011-05-24 01:16:45 UTC 
Bookkeeping - closing bug - fixed in recent release.
Comment 7 Corey Welton 2011-05-24 01:16:52 UTC 
Bookkeeping - closing bug - fixed in recent release.