Bug 637000

Summary:	spectool fails when an Icon tag exists
Product:	[Fedora] Fedora	Reporter:	Joe Krahn <krahn>
Component:	rpmdevtools	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	13	CC:	ville.skytta
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rpmdevtools-7.10-1.fc14	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-10-05 13:23:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joe Krahn 2010-09-23 22:28:56 UTC

Description of problem:
spectool silently fails on SPEC files that contain an Icon tag. It runs `rpmbuild' with %_sourcedir directed to a temporary directory, and rpmbuild exists when the Icon file is missing, before any Source or Patch filenames are printed.

Version-Release number of selected component (if applicable):
7.8-1

How reproducible:
always

Steps to Reproduce:
1. spectool XXXX.spec
   # where XXX.spec contains   Icon: <filename>

Actual results:
Fails silently

Expected results:
Normal processing, or at least an error message.

Additional info:
The easy fix is to just strip the Icon tag from the generated temporary
spec file, because it does not (yet) support a URL syntax.

Comment 1 Ville Skyttä 2010-09-27 16:42:48 UTC

ACK.  A similar problem exists with BuildArchitectures (the short BuildArch form is not a problem).

Comment 2 Fedora Update System 2010-09-27 18:41:06 UTC

rpmdevtools-7.10-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rpmdevtools-7.10-1.fc14

Comment 3 Fedora Update System 2010-09-27 18:47:11 UTC

rpmdevtools-7.10-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rpmdevtools-7.10-1.fc13

Comment 4 Fedora Update System 2010-09-27 20:06:48 UTC

rpmdevtools-7.10-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rpmdevtools'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rpmdevtools-7.10-1.fc14

Comment 5 Fedora Update System 2010-10-05 13:23:39 UTC

rpmdevtools-7.10-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2010-10-08 20:44:30 UTC

rpmdevtools-7.10-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.