Bug 638948
| Summary: | Review Request: erlang-getopt - Erlang module to parse command line arguments using the GNU getopt syntax | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Nathaniel McCallum <nathaniel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, nathaniel, notting |
| Target Milestone: | --- | Flags: | nathaniel:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | erlang-getopt-0.3-3.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-14 14:13:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 639263 | ||
|
Description
Peter Lemenkov
2010-09-30 13:24:00 UTC
[ OK ] specfiles match: 5d0348a502988cf7922a9a83a6d2f3cf [ OK ] source files match upstream: 1657e6c5d68889befcbae30cd8df805d [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ FAIL ] license field matches the actual license. Listed license is MIT, actual is 3-clause BSD. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ FAIL ] rpmlint is silent. Example scripts should be 644, they are a form of documentation. The should also be installed as %doc. Does chmod'ing the scripts 644 make the doc-file-dependency go away? [ OK ] final provides and requires are sane [ OK ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ FAIL ] file permissions are appropriate. %doc scripts should be 644 [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. Done: http://peter.fedorapeople.org/erlang-getopt.spec http://peter.fedorapeople.org/erlang-getopt-0.3-2.fc12.src.rpm New rpmlint output: erlang-getopt.src: W: invalid-url Source0: jcomellas-getopt-v0.3-0-g8f54692.tar.gz erlang-getopt.x86_64: E: no-binary erlang-getopt.x86_64: W: only-non-binary-in-usr-lib All of these are ok. Changing the permission on the example scripts fixed all the other warnings. License issue fixed. APPROVED New Package SCM Request ======================= Package Name: erlang-getopt Short Description: Erlang module to parse command line arguments using the GNU getopt syntax Owners: peter Branches: f12 f13 f14 el6 el5 InitialCC: Git done (by process-git-requests). erlang-getopt-0.3-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-getopt-0.3-2.fc13 erlang-getopt-0.3-2.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/erlang-getopt-0.3-2.fc12 erlang-getopt-0.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-getopt-0.3-2.fc14 erlang-getopt-0.3-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-getopt'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-getopt-0.3-2.fc14 erlang-getopt-0.3-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-getopt-0.3-3.el5 erlang-getopt-0.3-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. erlang-getopt-0.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. erlang-getopt-0.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. erlang-getopt-0.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |