Bug 638960 (CVE-2010-3704)

Summary: CVE-2010-3704 xpdf: array indexing error in FoFiType1::parse()
Product: [Other] Security Response Reporter: Tomas Hoger <thoger>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: andreas.bierfert, jnovy, mjc, mkasik, orion, rdieter, tcallawa, than, tremble, vdanen
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: impact=important,public=20100924,reported=20100929,source=oss-security,cvss2=6.8/AV:N/AC:M/Au:N/C:P/I:P/A:P,rhel-3/xpdf=notaffected,rhel-4/xpdf=affected,rhel-4/gpdf=affected,rhel-4/kdegraphics=affected,rhel-4/tetex=notaffected,rhel-4/cups=notaffected,rhel-5/poppler=affected,rhel-5/kdegraphics=affected,rhel-5/tetex=affected,rhel-6/poppler=affected,fedora-all/poppler=affected
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-26 11:46:12 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 639829, 639830, 639831, 639832, 639833, 639834, 639839, 639840, 639841, 639842, 639859, 639860, 639861, 639868, 639875, 652108, 773178, 773180, 833917    
Bug Blocks: 638835    

Description Tomas Hoger 2010-09-30 09:52:36 EDT
An array indexing error was found in the way xpdf / poppler parsed Type1 fonts embedded in PDF documents.  In FoFiType1::parse(), text representation of the numeric code value was converted to integer value using atoi().  This value was checked to ensure it's less than 256, but there was no check to ensure it's not negative (string passed to atoi() was checked to only contain characters '0'-'9' before the call though).  On platforms, where atoi() could return negative result when parsing large positive values (exceeding INT_MAX), this could could lead to write out of array bounds due to use of negative index.

poppler upstream commit:
http://cgit.freedesktop.org/poppler/poppler/commit/?id=39d140bfc0b8239bdd96d6a55842034ae5c05473

Reference:
http://secunia.com/advisories/41596/
Comment 2 Tomas Hoger 2010-09-30 10:00:14 EDT
(In reply to comment #0)
> On platforms, where atoi() could return negative result when parsing large
> positive values (exceeding INT_MAX), this could could lead to write out of
> array bounds due to use of negative index.

This does happen on e.g. x86_64, but does not happen on i386.

Affected code is present in xpdf versions 3.00 and later, it is not part of xpdf 2.x (so EL3 is not affected, EL4 tetex is not affected).
Comment 4 Huzaifa S. Sidhpurwala 2010-10-04 04:55:33 EDT
Created poppler tracking bugs for this issue

Affects: fedora-all [bug 639861]
Comment 7 Tomas Hoger 2010-10-07 10:40:42 EDT
This is likely to affect other applications that embed xpdf code, such as pdfedit and koffice 1.x.  Official xpdf patch may appear later this week.
Comment 8 errata-xmlrpc 2010-10-07 11:05:21 EDT
This issue has been addressed in following products:

  Red Hat Enterprise Linux 5

Via RHSA-2010:0749 https://rhn.redhat.com/errata/RHSA-2010-0749.html
Comment 9 errata-xmlrpc 2010-10-07 11:26:27 EDT
This issue has been addressed in following products:

  Red Hat Enterprise Linux 4

Via RHSA-2010:0751 https://rhn.redhat.com/errata/RHSA-2010-0751.html
Comment 10 errata-xmlrpc 2010-10-07 11:31:51 EDT
This issue has been addressed in following products:

  Red Hat Enterprise Linux 4

Via RHSA-2010:0752 https://rhn.redhat.com/errata/RHSA-2010-0752.html
Comment 11 errata-xmlrpc 2010-10-07 11:52:24 EDT
This issue has been addressed in following products:

  Red Hat Enterprise Linux 4
  Red Hat Enterprise Linux 5

Via RHSA-2010:0753 https://rhn.redhat.com/errata/RHSA-2010-0753.html
Comment 12 Tomas Hoger 2010-10-25 04:13:09 EDT
xpdf upstream fixed this via xpdf-3.02pl5.patch, see bug #595245, comment #22.
Comment 13 errata-xmlrpc 2010-11-10 14:17:58 EST
This issue has been addressed in following products:

  Red Hat Enterprise Linux 6

Via RHSA-2010:0859 https://rhn.redhat.com/errata/RHSA-2010-0859.html
Comment 14 errata-xmlrpc 2012-08-23 10:58:07 EDT
This issue has been addressed in following products:

  Red Hat Enterprise Linux 5

Via RHSA-2012:1201 https://rhn.redhat.com/errata/RHSA-2012-1201.html