Bug 638974
| Summary: | Review Request: erlang-protobuffs - A set of Protocol Buffers tools and modules for Erlang applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Nathaniel McCallum <nathaniel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, nathaniel, notting |
| Target Milestone: | --- | Flags: | nathaniel:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | erlang-protobuffs-0-0.2.20100930git58ff962.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-14 14:09:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 639263, 652543, 652598 | ||
|
Description
Peter Lemenkov
2010-09-30 14:24:09 UTC
[ OK ] specfiles match: 05114befc722dc9d5160b22246bba92c [ OK ] source files match upstream: ef08e31d3b08548d820e9508de57a31d [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ FAIL ] license field matches the actual license. License is MIT, not BSD. [ OK ] license is open source-compatible. [ NA ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ OK ] rpmlint is silent. erlang-protobuffs.ppc: E: explicit-lib-dependency erlang-stdlib erlang-protobuffs.ppc: E: no-binary erlang-protobuffs.ppc: W: only-non-binary-in-usr-lib These are all false positives. [ OK ] final provides and requires are sane [ OK ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. Fix the license and we are good to go. Done: http://peter.fedorapeople.org/erlang-protobuffs.spec http://peter.fedorapeople.org/erlang-protobuffs-0-0.2.20100930git58ff962.fc12.src.rpm APPROVED New Package SCM Request ======================= Package Name: erlang-protobuffs Short Description: A set of Protocol Buffers tools and modules for Erlang applications Owners: peter Branches: f12 f13 f14 el6 el5 InitialCC: Git done (by process-git-requests). erlang-protobuffs-0-0.2.20100930git58ff962.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-protobuffs-0-0.2.20100930git58ff962.fc14 erlang-protobuffs-0-0.2.20100930git58ff962.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/erlang-protobuffs-0-0.2.20100930git58ff962.fc12 erlang-protobuffs-0-0.2.20100930git58ff962.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-protobuffs-0-0.2.20100930git58ff962.el5 erlang-protobuffs-0-0.2.20100930git58ff962.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-protobuffs-0-0.2.20100930git58ff962.fc13 erlang-protobuffs-0-0.2.20100930git58ff962.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-protobuffs'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-protobuffs-0-0.2.20100930git58ff962.el5 erlang-protobuffs-0-0.2.20100930git58ff962.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. erlang-protobuffs-0-0.2.20100930git58ff962.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. erlang-protobuffs-0-0.2.20100930git58ff962.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. erlang-protobuffs-0-0.2.20100930git58ff962.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |