Bug 63911
| Summary: | CVS crash if .cvspass not accessible | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Itai Nahshon <itai.nahshon> | ||||
| Component: | cvs | Assignee: | Eido Inoue <havill> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Ben Levenson <benl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.2 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2004-10-18 19:04:39 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 54804 [details]
Suggested patch (apply after cvs-1.11.1p1-cvspass.patch)
cvs-1.11.17-cvspass.patch contains this fix. |
Description of Problem: Cvs (client side when using pserver) is crashing if the .cvspass file is not accessible. Version-Release number of selected component (if applicable): cvs-1.11.1p1-7 How Reproducible: The easy way is to change the HOME environment variable to a non-existent or unreadable directory. Then try any cvs command that tries to access a pserver. Same thing has happened when I tried a cvs command from sudo (it does not change $HOME, so the target user cannot access .cvspass). Actual Results: Segmentation fault (core dumped) Expected Results: (error message) Additional Information: The problem is in cvs-1.11.1p1-cvspass.patch (fromn the RedHat SRPM): + fp = CVS_FOPEN (passfile, "w"); + fclose (fp); If the fopen failed then the fclose will segfault.