Bug 639286

Koji build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2505945

rpmlint:

$ rpmlint rubygem-amazon-ec2-0.9.15-1.fc13.noarch.rpm 
rubygem-amazon-ec2.noarch: W: no-manual-page-for-binary ec2sh

Some notes

* Unused macros
  - %ruby_sitelib macro seems used nowhere.

* License tag
  - When the license text says "under the same terms as Ruby",
    this is "GPLv2 or Ruby" on Fedora.

* Explicit version dependencies
  - As far as I checked for these explicit version dependencies.
    it seems only ">= 0.9.8" for rubygem(mocha) is needed.

* (Build)Requires
  - rubygem(mocha) is only for s.add_development_dependency in
    gemspec file and not needed for runtime (Requires).

* Document files
  - Please consider to create -doc subpackage and move document
    files (like test/ Rakefile %{gemdir}/doc/ %geminstdir/foo.gemspec
    and perhaps deps.rip wsdl perftools) into -doc.

By the way I would appreciate it if you would review my
gem related review request (bug 637904)

(In reply to comment #2)
> Some notes
> 
> * Unused macros
>   - %ruby_sitelib macro seems used nowhere.
> 
> * License tag
>   - When the license text says "under the same terms as Ruby",
>     this is "GPLv2 or Ruby" on Fedora.

Fixed.

> 
> * Explicit version dependencies
>   - As far as I checked for these explicit version dependencies.
>     it seems only ">= 0.9.8" for rubygem(mocha) is needed.

Version dependencies removed.

> 
> * (Build)Requires
>   - rubygem(mocha) is only for s.add_development_dependency in
>     gemspec file and not needed for runtime (Requires).

Mocha removed from runtime. Thanks for catching it.

> 
> * Document files
>   - Please consider to create -doc subpackage and move document
>     files (like test/ Rakefile %{gemdir}/doc/ %geminstdir/foo.gemspec
>     and perhaps deps.rip wsdl perftools) into -doc.

Sure, documentation and support files moved to -doc subpackage.

===================================================================

* Wed Oct 06 2010 Michal Fojtik <mfojtik> - 0.9.15-2
- Removed unused macros
- Fixed license and version dependencies
- Moved documentation files into -doc subpackage

SRPM: http://mifo.sk/RPMS/rubygem-amazon-ec2-0.9.15-2.fc13.src.rpm
Spec: http://mifo.sk/RPMS/rubygem-amazon-ec2.spec

For -2:

* %defattr on -doc subpackage
  - Please set %defattr on -doc subpackage

* Document files
  - license files or so should be in main package. Please
    move the following files to main package, and mark them
    as %doc (in main package)
------------------------------------------------------
%{geminstdir}/ChangeLog
%{geminstdir}/LICENSE
%{geminstdir}/VERSION
%{geminstdir}/README.rdoc
------------------------------------------------------

Please fix the above when importing this package
into Fedora.
------------------------------------------------------
    This package (rubygem-amazon-ec2) is APPROVED
    by mtasaka
------------------------------------------------------

Thank you! Both things are fixed now.

New Package SCM Request
=======================
Package Name:      rubygem-amazon-ec2
Short Description:  A Ruby library for accessing the Amazon Web Services
Owners:            mfojtik
Branches:          f12 f13 f14

Git done (by process-git-requests).

rubygem-amazon-ec2-0.9.15-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-amazon-ec2-0.9.15-3.fc13

rubygem-amazon-ec2-0.9.15-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-amazon-ec2-0.9.15-3.fc14

rubygem-amazon-ec2-0.9.15-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-amazon-ec2-0.9.15-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.