Bug 639586

Created attachment 451183 [details]
File: backtrace

Fixed upstream.

http://git.fedorahosted.org/git/?p=system-config-printer.git;a=commitdiff;h=30adc52384db438077f6c423f8729228bc5b2d28

http://git.fedorahosted.org/git/?p=system-config-printer.git;a=commitdiff;h=a14fe4d742a3d68dea376dc2c07bdca0b870725d

(In reply to comment #2)
> http://git.fedorahosted.org/git/?p=system-config-printer.git;a=commitdiff;h=30adc52384db438077f6c423f8729228bc5b2d28

I think the intention with that code is to loop through each node, deleting and freeing all of them.  So something like:

while queue_node:
  ...
  next_node = queue_node.next
  queue_node.unlinkNode ()
  queue_node.freeNode ()
  queue_node = next_node

What do you think?

(In reply to comment #3)
> I think the intention with that code is to loop through each node,
> deleting and freeing all of them.
Not all of them but only the one whose property "name" is the same as queue_name.
If there's no such node, no node will be freed.

So the current code
                while queue_node:
                    if queue_node.prop ("name") == queue_name:
                        break
                    queue_node = queue_node.next
                if queue_node:
                    queue_node.unlinkNode ()
                    queue_node.freeNode ()
could better look like
                while queue_node:
                    if queue_node.prop ("name") == queue_name:
                        queue_node.unlinkNode ()
                        queue_node.freeNode ()
                        break
                    queue_node = queue_node.next

Am I still missing something ?
Should I commit the above change or is it only a detail ?

Ah, yes, I understand now.  No need to change it.

system-config-printer-1.2.5-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc14

system-config-printer-1.2.5-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13

system-config-printer-1.2.5-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13

This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

(In reply to comment #8)
> system-config-printer-1.2.5-1.fc13 has been pushed to the Fedora 13 testing
> repository.  If problems still persist, please make note of it in this bug
> report.
>  If you want to test the update, you can install it with 
>  su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You
> can provide feedback for this update here:
> https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13

Noted down though since I worked around this bug it is not a priority to me to use it again for the moment.
But in case of need to use it again, I will install the update-testing version then report any result.
Regards

system-config-printer-1.2.5-6.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

system-config-printer-1.2.5-6.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.