Bug 641015
| Summary: | Review Request: rubygem-cri - Cri is a library for building easy-to-use commandline tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-cri-1.0.1-3.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-10 01:10:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 641018 | ||
|
Description
Michal Fojtik
2010-10-07 14:26:08 UTC
Some notes: * Summary - "Cri is a" is redundant for Summary * License tag - The license tag for this package should be "MIT". * Documentation - I think %geminstdir/Rakefile can be in -doc. (In reply to comment #1) > Some notes: > > * Summary > - "Cri is a" is redundant for Summary Changed. > > * License tag > - The license tag for this package should be "MIT". Fixed. > > * Documentation > - I think %geminstdir/Rakefile can be in -doc. File moved to -doc. ======================= 1.0.1-2 =================== * Sun Oct 17 2010 Michal Fojtik <mfojtik> - 1.0.1-2 - Fixed version to MIT - Rakefile moved to -doc - Changed summary text Spec URL: http://mifo.sk/RPMS/rubygem-cri.spec SRPM URL: http://mifo.sk/RPMS/rubygem-cri-1.0.1-1.fc13.src.rpm Well,
* I think %doc attribute on Rakefile in -doc subpackage is redundant.
* Please correctly modify release number
* Please set %defattr(-,root,root,-) on -doc subpackage, too
Please fix the issue above when importing this package into
Fedora.
---------------------------------------------------------------
This package (rubygem-cri) is APPROVED by mtasaka
---------------------------------------------------------------
ping? Thank you for the review and sorry for that delay! New Package SCM Request ======================= Package Name: rubygem-cri Short Description: Library for building easy-to-use commandline tools Owners: mfojtik Branches: f12 f13 f14 Git done (by process-git-requests). rubygem-cri-1.0.1-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-cri-1.0.1-3.fc13 rubygem-cri-1.0.1-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-cri-1.0.1-3.fc14 rubygem-cri-1.0.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-cri'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-cri-1.0.1-3.fc13 rubygem-cri-1.0.1-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. rubygem-cri-1.0.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |