Bug 641018
| Summary: | Review Request: rubygem-nanoc3 - A web publishing system written in Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mfojtik, mtasaka, notting, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-01 15:20:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 641015 | ||
| Bug Blocks: | 201449 | ||
|
Description
Michal Fojtik
2010-10-07 14:35:31 UTC
Some questions first:
* About Requires related to lib/nanoc3/filters/
- Are Requires related to lib/nanoc3/filers always required
for this rpm?
According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/
are loaded only when actually using such filters, and when not
using such filters the listed rpms don't seem to be needed.
- And for the same reason, do filters of which the dependencies
are not found on Fedora really have to be removed?
The filter scripts don't seem to be loaded automatically.
(In reply to comment #1) > Some questions first: > > * About Requires related to lib/nanoc3/filters/ > - Are Requires related to lib/nanoc3/filers always required > for this rpm? > According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/ > are loaded only when actually using such filters, and when not > using such filters the listed rpms don't seem to be needed. Yes that true. But to guarantee basic functionality for user, it's necessary to include that gems. Otherwise functionality that is related with those gems will be not available. And if they are already packaged for Fedora, I can't see the reason for omitting them as a dependencies. > > - And for the same reason, do filters of which the dependencies > are not found on Fedora really have to be removed? > The filter scripts don't seem to be loaded automatically. That's correct. I will keep all those filters here. (In reply to comment #2) > (In reply to comment #1) > > Some questions first: > > > > * About Requires related to lib/nanoc3/filters/ > > - Are Requires related to lib/nanoc3/filers always required > > for this rpm? > > According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/ > > are loaded only when actually using such filters, and when not > > using such filters the listed rpms don't seem to be needed. > > Yes that true. But to guarantee basic functionality for user, - So yes, we want to make rpms installed which is needed for "basic" functionality on this gem, however are all scripts under lib/nanoc3/filters classified as "basic" functionality for this rpm? For example, even without the rpms for the dependency of filters installed at all, $ ruby -rubygems -e 'require "nanoc3" ; puts Nanoc3::VERSION' works. > it's necessary to > include that gems. Otherwise functionality that is related > with those gems will be not available. - Just by default. So people can install the needed rpms afterwards when people wants to use the functionality. > And if they are already packaged for Fedora, I can't see the reason for > omitting them as a dependencies. - For people not using all of the filter functionality, not using unneeded rpms if possible is preferable. ping? ping again? Again ping? I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK. (In reply to comment #7) > I will close this bug as NOTABUG if no response is received > from the reporter within ONE WEEK. Hi, I was terribly busy last few weeks, sorry for this horrible delay. So I removed all filter dependencies and also bump version to 3.1.6. I keep rack dependency because it's required for 'server' functionality. ======================= 3.1.6-1 ======================= * Mon Nov 29 2010 Michal Fojtik <mfojtik> - 3.1.6-1 - Removed filter dependencies - Version bump Spec URL: http://mifo.sk/RPMS/rubygem-nanoc3.spec SRPM URL: http://mifo.sk/RPMS/rubygem-nanoc3-3.1.6-1.fc14.src.rpm Sorry, it seems I have forgotton this review. Then how about this issue? (In reply to comment #2) > > - And for the same reason, do filters of which the dependencies > > are not found on Fedora really have to be removed? > > The filter scripts don't seem to be loaded automatically. > > That's correct. I will keep all those filters here. So I think the lines like -------------------------------------------------------------- 51 rm -f %{buildroot}/%{geminstdir}/lib/nanoc3/filters/sass.rb --------------------------------------------------------------- are not needed. Anything happening here? The links in comment 8 are dead, and of course we have all-new Ruby packaging guidelines now. Marking this as NotReady since there's nothing currently to review; please clear the whiteboard if providing a package. |