Bug 641471
| Summary: | Review Request: python26-mod_wsgi - A WSGI interface for Python web applications in Apache | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | BJ Dierkes <derks> |
| Component: | Package Review | Assignee: | Carl Thompson <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, fedora, jorton, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python26-mod_wsgi-3.3-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-12 16:50:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
BJ Dierkes
2010-10-08 19:34:47 UTC
Thanks BJ! I would expect this needs to "Conflict: mod_wsgi" since the directives will clash and they can't be used together, no? There is currently a thread on the EPEL devel mailing list regarding just that. https://www.redhat.com/archives/epel-devel-list/2010-October/msg00043.html Personally, I think it should explicitly 'Conflict: mod_wsgi' and I previously had the explicit conflicts in both python26-mod_wsgi and python26-mod_python... however the EPEL policy regarding this isn't exactly clear so there is some discrepancy. Some people lean toward the Fedora policy which is to never explicitly conflict because it is confusing to the user. I'm hoping to clarify it in the EPEL Sig meeting (#fedora-meeting) on Monday at 19:30 UTC. You're welcome to provide your feedback on list or in the meeting. Thank Joe. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. See below - Meets Packaging Guidelines. See below - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 6172bb2bbabcd0c25867c2bc06f99dbb mod_wsgi-3.3.tar.gz 6172bb2bbabcd0c25867c2bc06f99dbb mod_wsgi-3.3.tar.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin rpmlint python26-mod_wsgi-3.3-1.fc13.src.rpm python26-mod_wsgi.src: W: spelling-error %description -l en_US wsgi -> swig, wigs python26-mod_wsgi.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish python26-mod_wsgi.src: W: invalid-url Source0: http://modwsgi.googlecode.com/files/mod_wsgi-3.3.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint -i python26-mod_wsgi-3.3-1.fc13.src.rpm python26-mod_wsgi.src: W: spelling-error %description -l en_US wsgi -> swig, wigs The value of this tag appears to be misspelled. Please double-check. python26-mod_wsgi.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish The value of this tag appears to be misspelled. Please double-check. python26-mod_wsgi.src: W: invalid-url Source0: http://modwsgi.googlecode.com/files/mod_wsgi-3.3.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 0 errors, 3 warnings. The url is valid even if rpmlint says it isn't, confirmed manually I like the approach of not putting it in Conflicts but using the conf file to ensure that both modules are not loaded into apache simultaneously New Package SCM Request ======================= Package Name: python26-mod_wsgi Short Description: A WSGI interface for Python web applications in Apache Owners: derks Branches: el5 InitialCC: Git done (by process-git-requests). python26-mod_wsgi-3.3-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python26-mod_wsgi-3.3-1.el5 python26-mod_wsgi-3.3-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python26-mod_wsgi'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python26-mod_wsgi-3.3-1.el5 python26-mod_wsgi-3.3-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |