Bug 642546

Summary: Empty config fields are editable for a user having only config_read permission
Product: [Other] RHQ Project Reporter: Sunil Kondkar <skondkar>
Component: Core UIAssignee: Ian Springer <ian.springer>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0.0CC: ccrouch, ian.springer
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 640268    
Attachments:
Description Flags
Screenshot none

Description Sunil Kondkar 2010-10-13 09:57:37 UTC
Description of problem:

If a user has only config_read permission and navigates to configuration tab of a resource like 'RHQ Agent', the empty config properties are editable. If user enters value in any of such properties, save button also gets enabled.

Please refer the attached screenshot.

Version-Release number of selected component (if applicable):
build#409

How reproducible:
Always

Steps to Reproduce:

1.Login to Jon
2.Create a group of resources like rhq agent etc
3.Create a role having only view config permisions and assign the resource group created.
4.Create a new user and assign the role created above
5.Login to Jon as newly created user
6.Navigate to 'Inventory->Servers->RHQ Agent->Configuration->Current' tab.
7.Uncheck the ckeckbox for a empty config property say 'Server Discovery Period'.
8.Enter a value in the text box (Ex: 30)
9.Notice the 'Save' button is enabled. 
  
Actual results:

The empty config fields are editable for a user having only config_read permission.

Expected results:

User having only config_read permission should be able to only view the individual configuration values. The config properties should not be editable.

Additional info:

Comment 1 Sunil Kondkar 2010-10-13 09:59:45 UTC
Created attachment 453157 [details]
Screenshot

Comment 2 Ian Springer 2011-03-01 17:42:21 UTC
Fixed - [master d27c97e]. The underlying cause was fault logic in
ConfigurationEditor.isReadOnly().

Comment 3 Sunil Kondkar 2011-03-04 11:36:33 UTC
Verified on Build#1063 (Version: 4.0.0-SNAPSHOT Build Number: f86ed17)

User having only config_read permission is able to only view the individual configuration values.

Marking as verified.

Comment 4 Corey Welton 2011-05-24 01:15:01 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 5 Corey Welton 2011-05-24 01:15:13 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 6 Corey Welton 2011-05-24 01:15:14 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 7 Corey Welton 2011-05-24 01:15:19 UTC
Bookkeeping - closing bug - fixed in recent release.