Bug 642592

I will take this review.

(Once reverting the previous change)

This review it's just NONFORMAL because i'm not in Fedora Packager Group right
now.

rpmlint rubygem-macaddr-1.0.0-1.fc13.src.rpm 
rubygem-macaddr.src: W: no-buildroot-tag
rubygem-macaddr.src:35: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab: line 16)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[BAD - in spec-file at line 15 is empty row and at line 16 is abundant tab character]

MUST: The License field in the package spec file must match the actual license.

License: GPLv2+ or Ruby

[OK? - gem doesn't contain LICENSE]

Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
like:
Requires: ruby(abi) = 1.8

[OK - this MUST condition is written via macro in this spec file]

Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname
is the name from the Gem's specification.

%global gemname macaddr
Name: rubygem-%{gemname}

[OK]

The Source of the package MUST be the full URL to the released Gem archive

URL: http://codeforpeople.com/lib/ruby/macaddr/
Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem

[OK]

The version of the package MUST be the Gem's version

Version: 1.0.0

[OK]

The package MUST have a Requires and a BuildRequires on rubygems

%global rubyabi 1.8

Requires:	ruby(abi) = %{rubyabi}
Requires: rubygems >= 0
Requires: ruby >= 0
BuildRequires: rubygems >= 0
BuildRequires: ruby >= 0

[BAD - need remove tab character at line 16, and checking againt zero version is not needed]

The Gem MUST be installed into %{gemdir} defined as:
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

[OK]

If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch

[OK]

The package MUST own the following files and directories:

%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

[OK? - it doesn't contain directory gems, but i think that in this case it isn't necessary]

The install SHOULD be performed with the command

gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} 

[OK]

(In reply to comment #3)
> This review it's just NONFORMAL because i'm not in Fedora Packager Group right
> now.
> 
> rpmlint rubygem-macaddr-1.0.0-1.fc13.src.rpm 
> rubygem-macaddr.src: W: no-buildroot-tag
> rubygem-macaddr.src:35: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab:
> line 16)
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> [BAD - in spec-file at line 15 is empty row and at line 16 is abundant tab
> character]
> 
> MUST: The License field in the package spec file must match the actual license.
> 
> License: GPLv2+ or Ruby
> 
> [OK? - gem doesn't contain LICENSE]
> 
> Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
> like:
> Requires: ruby(abi) = 1.8
> 
> [OK - this MUST condition is written via macro in this spec file]
> 
> Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname
> is the name from the Gem's specification.
> 
> %global gemname macaddr
> Name: rubygem-%{gemname}
> 
> [OK]
> 
> The Source of the package MUST be the full URL to the released Gem archive
> 
> URL: http://codeforpeople.com/lib/ruby/macaddr/
> Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
> 
> [OK]
> 
> The version of the package MUST be the Gem's version
> 
> Version: 1.0.0
> 
> [OK]
> 
> The package MUST have a Requires and a BuildRequires on rubygems
> 
> %global rubyabi 1.8
> 
> Requires: ruby(abi) = %{rubyabi}
> Requires: rubygems >= 0
> Requires: ruby >= 0
> BuildRequires: rubygems >= 0
> BuildRequires: ruby >= 0
> 
> [BAD - need remove tab character at line 16, and checking againt zero version
> is not needed]
> 
> The Gem MUST be installed into %{gemdir} defined as:
> %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
> 
> [OK]
> 
> If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch
> 
> [OK]
> 
> The package MUST own the following files and directories:
> 
> %{gemdir}/gems/%{gemname}-%{version}/
> %{gemdir}/cache/%{gemname}-%{version}.gem
> %{gemdir}/specifications/%{gemname}-%{version}.gemspec
> 
> [OK? - it doesn't contain directory gems, but i think that in this case it
> isn't necessary]
> 
> The install SHOULD be performed with the command
> 
> gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} 
> 
> [OK]

Please check this review also someone else (the best, who is sponsor)

Michal, please update the spec with a correct licence.

https://github.com/btakita/rr/blob/master/LICENSE

Good catch, thanks. Updated files:

Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm

(In reply to comment #6)
> Good catch, thanks. Updated files:
> 
> Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec
> SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm

This Spec and SRPM aren't for this gem. It should be in rubygem-rr. Please load the right ones.

(In reply to comment #7)
> (In reply to comment #6)
> > Good catch, thanks. Updated files:
> > 
> > Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec
> > SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.noarch.rpm
> 
> This Spec and SRPM aren't for this gem. It should be in rubygem-rr. Please load
> the right ones.

Sorry for that:

Spec URL: http://mifo.sk/RPMS/rubygem-rr.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rr-1.0.0-3.fc14.src.rpm

Could you provide updates spec file please?

(In reply to comment #9)
> Could you provide updates spec file please?

I hope this one will be correct finally:

http://mifo.sk/RPMS/rubygem-macaddr.spec
http://mifo.sk/RPMS/rubygem-macaddr-1.0.0-1.fc13.src.rpm

I am taking this for review after Jozef.

rev-2:

http://mifo.sk/RPMS/rubygem-macaddr.spec
http://mifo.sk/RPMS/rubygem-macaddr-1.0.0-2.fc13.src.rpm

* License
  - according to macaddr rubyforge home page 
    (http://rubyforge.org/projects/codeforpeople/) the gem is licensed just under
    Ruby license.
  - You should encourage upstream to add license file:
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

* Cleaning
  - "rm -rf %{buildroot}" at the top of %install, %clean section
    are no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Splitting out document files
  - Please consider to create -doc subpackage and move the 
    %{gemdir}/doc/%{gemname}-%{version} directories into -doc

* Rpmlint
  - incoherent-version-in-changelog 1.0.0-1 ['1.0.0-2.fc15', '1.0.0-2']
  - Please fix the revision in changelog.

Koji build looks fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2971863

Ping? Any update here?

Ping?

It seem to be stalled. Please reopen or create new review if you are still interested in this gem.

*** This bug has been marked as a duplicate of bug 1177697 ***