Bug 642995

Hello, Jordan:

As far as I checked FAS, you are not yet a member of "packager" group.
Would you tell me if this is correct?

A person who is going to assign review request ticket to him/herself and
to review ticket formally must be in "packager" group and so must be
sponsored when becoming a member of "packager" group.

Greetings, I'm willing to sponsor Jordan.  As part of that, I've asked him to review a package he's interested in and I'll sponsor him as one of the final steps so he can finish the review.  Thanks for keeping an eye out.

Thanks for sponsoring me, Toshio!

Michal: everything looks good. There is one optional warning from rpmlint that you might want to address, but otherwise nice work.

rpmlint output: good
package name : good
spec file name : good
Packaging Guidelines : good
license included (ASL2): good
sources match upstream : good
builds for me on F13 : good
build dependencies : good
locales: good
no shared system libraries : good
correct directory ownership : good
no duplicate file ownership : good
permissions : good
macros : good
documentation : good
rubygem specific build config : good

My only suggestion is the warning from rpmlint: 

   rubygem-deltacloud-client.spec: W: no-buildroot-tag

A BuildRoot directive is required for older distros (RHEL5), and would be handy.

Good work!

Thank you for the review!

New Package SCM Request
=======================
Package Name:      rubygem-deltacloud-client
Short Description: Deltacloud REST Client 
Owners:            mfojtik
Branches:          f12 f13 f14

Git done (by process-git-requests).

rubygem-deltacloud-client-0.1.0-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-1.fc13

rubygem-deltacloud-client-0.1.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-1.fc14

rubygem-deltacloud-client-0.1.0-1.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-1.fc12

rubygem-deltacloud-client-0.1.0-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-2.fc13

rubygem-deltacloud-client-0.1.0-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-2.fc14

rubygem-deltacloud-client-0.1.0-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-2.fc12

However currently rest-client >= 1.4.2 is really needed.

[root@localhost ~]# rpm -q rubygem-deltacloud-client rubygem-rest-client
rubygem-deltacloud-client-0.1.0-2.fc14.noarch
rubygem-rest-client-1.4.0-6.fc14.noarch
[root@localhost ~]# ruby -rubygems -e 'gem "deltacloud-client"'
/usr/lib/ruby/site_ruby/1.8/rubygems.rb:779:in `report_activate_error': RubyGem version error: rest-client(1.4.0 not >= 1.4.2) (Gem::LoadError)
        from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:214:in `activate'
        from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:249:in `activate'
        from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `each'
        from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `activate'
        from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:1082:in `gem'
        from -e:1

rubygem-deltacloud-client-0.1.0-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-deltacloud-client'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.1.0-1.fc13

(In reply to comment #12)
> However currently rest-client >= 1.4.2 is really needed.
> 
> [root@localhost ~]# rpm -q rubygem-deltacloud-client rubygem-rest-client
> rubygem-deltacloud-client-0.1.0-2.fc14.noarch
> rubygem-rest-client-1.4.0-6.fc14.noarch
> [root@localhost ~]# ruby -rubygems -e 'gem "deltacloud-client"'
> /usr/lib/ruby/site_ruby/1.8/rubygems.rb:779:in `report_activate_error': RubyGem
> version error: rest-client(1.4.0 not >= 1.4.2) (Gem::LoadError)
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:214:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:249:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `each'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:248:in `activate'
>         from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:1082:in `gem'
>         from -e:1

Going to update rest-client. Thanks for find out this one.

rubygem-deltacloud-client-0.1.0-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-deltacloud-client-0.1.0-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-deltacloud-client-0.3.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.3.0-1.fc14

rubygem-deltacloud-client-0.3.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.3.1-1.fc14

rubygem-deltacloud-client-0.3.1-1.fc14 has been pushed to the Fedora 14 stable repository.