Bug 643292

Good idea Yufang, thanks for tracking down the upstream patch. Laszlo, please
backport, test, and post this patch.

Drew

That patch was borked and updated on xen-changelog only.
Here's the patch to the original patch:

# HG changeset patch
# User Keir Fraser <keir>
# Date 1286877800 -3600
# Node ID 7fcbbb8c828503ae31a4a568c68d491dd8e0fe14
# Parent  578f036ec7dd46f2182849dce3757c709bc9883d
netfront: Fix build failure after previous changeset

From: Ian Campbell <Ian.Campbell>
Signed-off-by: Keir Fraser <keir>
Acked-by: Jan Beulich <jbeulich>
---
 drivers/xen/netfront/netfront.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 578f036ec7dd -r 7fcbbb8c8285 drivers/xen/netfront/netfront.c
--- a/drivers/xen/netfront/netfront.c	Mon Oct 11 10:25:55 2010 +0100
+++ b/drivers/xen/netfront/netfront.c	Tue Oct 12 11:03:20 2010 +0100
@@ -1776,7 +1776,7 @@ static void netfront_get_drvinfo(struct 
 				 struct ethtool_drvinfo *info)
 {
 	strcpy(info->driver, "netfront");
-	strcpy(info->bus_info, dev_name(dev->dev.parent));
+	strcpy(info->bus_info, dev->class_dev.dev->bus_id);
 }
 
 static int network_connect(struct net_device *dev)
for final patch...

Apologies for the late response!

I reproduced the bug in the PV guest:

[root@localhost ~]# uname -r
2.6.18-194.el5xen

[root@localhost ~]# ethtool -i eth0
Cannot get driver information: Operation not supported

First I tried to backport the originally linked-to patch [0] against jwilson/rhel5/kernel (master branch). To build the patched kernel, I took the kernel config file (config-2.6.18-227.el5) from jwilson's most recent build [1], more specifically the x86_64 normal kernel rpm.

As Don pointed out above, the original patch was broken and my build failed. I assumed this was my fault and that the build barfed due to an internals' divergence between jwilson's kernel and the kernel that [0] was submitted against. So I tried to alter the patch. I'm adding an attachment called "netfront-try0.patch" which contains my modified patch.

Testing it (brew output available under [2]):

[root@localhost ~]# uname -r
2.6.18-227.el5.bz643292xen

[root@localhost ~]# ethtool -i eth0
driver: xen-netfront
version: 
firmware-version: 
bus-info: xen

FWIW, I wrote this up here only for the record. I'll go on with porting back the patch as fixed by Don. Until I'm finished, I'll leave this entry as ASSIGNED.

Paolo tells me there's a similar patch for netback too; I plan to clone this bug with his help and backport the netback patch as well.

[0] http://lists.xensource.com/archives/html/xen-devel/2010-10/msg00416.html
[1] https://brewweb.devel.redhat.com/buildinfo?buildID=146165
[2] https://brewweb.devel.redhat.com/taskinfo?taskID=2828555

Created attachment 454064 [details]
Add get_drvinfo() support to xen netfront driver.

Obsolete as posted.

Testing v2 [0] of the patch:

[root@localhost ~]# uname -r
2.6.18-227.el5.bz643292_v2xen

[root@localhost ~]# ethtool -i eth0
driver: netfront
version: 
firmware-version: 
bus-info: vif-0

Will POST patch after devel_ack.

[0] https://brewweb.devel.redhat.com/taskinfo?taskID=2832368

Created attachment 454356 [details]
Add get_drvinfo() support to xen netfront driver, v2.

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

in kernel-2.6.18-243.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Verified with 2.6.18-243 build:

[root@localhost ~]# uname -a
Linux localhost 2.6.18-243.el5xen #1 SMP Mon Feb 7 18:58:50 EST 2011 i686 athlon i386 GNU/Linux
[root@localhost ~]# ethtool -i eth0
driver: netfront
version: 
firmware-version: 
bus-info: vif-0

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1065.html