Bug 644784

Description of problem:

This relates to the plugin testbind.c, available at:

http://cvs.fedoraproject.org/viewvc/ldapserver/ldap/servers/slapd/test-plugins/?root=dirsec

I have tested this plugin on "Red Hat Directory Server", but I guess that LDAP API is the same, so the problem will probably also hit "389 Directory Server" (and there is not a "Red Hat Directory Server" bugzilla section).

Version-Release number of selected component (if applicable):

Checked on Red Hat Directory Server version 8.1.0-0.14

How reproducible:

In the source code of testbind.c, there is:

rc = slapi_search_internal_get_entry( sdn, attrs, &e, plugin_id );

which, according to the Red Hat Directory Server Plugin Guide:

(http://docs.redhat.com/docs/en-US/Red_Hat_Directory_Server/8.2/html/Plug-in_Guide/Plugin_Programming_Guide-Function_Reference-slapi_search_internal_get_entry.html)

"set a copy of the entry", and " The returned entry (*ret_entry) should be freed by calling slapi_entry_free()."

In the code, there is no slapi_entry_free(). So the code should be changed with:


slapi_entry_free(e);
slapi_send_ldap_result( pb, rc, NULL, NULL, 0, NULL );
return( 1 );


where the first line is added, and the other two are from the original source code.

Doing this, there are still some memory leaks on the Directory Server, but they appears to be one shot (i.e. at startup time) and not recurring for every bind() client operation.

With valgrind, I get at "service dirsrv stop" this:

[...]
==29572== LEAK SUMMARY:
==29572==    definitely lost: 14,816 bytes in 312 blocks
==29572==    indirectly lost: 226,940 bytes in 11,067 blocks
==29572==      possibly lost: 40,773 bytes in 347 blocks
==29572==    still reachable: 8,201,212 bytes in 23,240 blocks
==29572==         suppressed: 0 bytes in 0 blocks


And these values are almost constant; otherwise, you see changing numbers (and increasing vsz size on ps output) according to the number of plugin invocations.



Note: this is already documented for the SUN Java System Directory Server:

http://forums.sun.com/thread.jspa?threadID=5050942