Bug 645703

Summary: Enable and fix testsuite in graphviz
Product: [Fedora] Fedora Reporter: Jaroslav Škarvada <jskarvad>
Component: graphvizAssignee: Patrick Laughton <jima>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jima, jskarvad, mnowak, rvokal, tremble
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: graphviz-2.26.3-2.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 624690 Environment:
Last Closed: 2011-01-06 23:30:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jaroslav Škarvada 2010-10-22 09:37:17 UTC
+++ This bug was initially created as a clone of Bug #624690 +++

Description of problem:

graphviz testsuite is enabled on some archs in spec file and thus on build time, however the testsuite fails in a lot of cases, e.g. on x86-64:

"""
+ make rtest
./rtest.sh
Test shapes:0 : == Failed == shapes_dot.gv
Test shapes:1 : == Failed == shapes_dot.ps
./rtest.sh[389]: doTest: line 279: 15415: Memory fault
Test crazy:0 : == Layout failed ==
  ../cmd/dot/dot_builtins -Kdot -Tpng  -ondata/crazy_dot.png graphs/crazy.gv
Test crazy:1 : == Failed == crazy_dot.ps
Test arrows:0 : == Failed == arrows_dot.gv
Test arrows:1 : == Failed == arrows_dot.ps
./rtest.sh[389]: doTest: line 279: 15485: Memory fault
[...]
"""

and is disabled for ppc*:

%check
%ifnarch ppc64 ppc sparc64
# regression test, segfaults on ppc/ppc64/sparc64, possible endian issues?
cd rtest
make rtest
%endif


It would be really helpful for QE if the testsuite passed and is enabled for all RHEL supported archs.

Version-Release number of selected component (if applicable):

graphviz-2.26.0-4.el6

--- Additional comment from pm-rhel on 2010-10-15 10:31:36 CEST ---

This bugzilla was reviewed by QE as a non-FasTrack request.
It has since been proposed for FasTrack. The qa_ack has 
been reset. QE needs to re-review this bugzilla for FasTrack.

--- Additional comment from jskarvad on 2010-10-22 11:03:53 CEST ---

Fixed SIGSEGVs and several other problems. But testsuite results are highly dependant on system configration / package versions used. The source data are processed by specially created test executable and the results are diffed with upstream supplied samples. Only one pixel shift will cause the test to fail. For now all tests are failing because the upstream samples seems to be a little outdated.

--- Additional comment from jskarvad on 2010-10-22 11:06:49 CEST ---

Created attachment 455022 [details]
Proposed SIGSEGVs fix

Fix segfaults caused by wrong initialization.

--- Additional comment from jskarvad on 2010-10-22 11:11:19 CEST ---

Created attachment 455023 [details]
Proposed rtest fix

Fix for counting differences even in case of error / warning output.

--- Additional comment from jskarvad on 2010-10-22 11:14:11 CEST ---

Created attachment 455024 [details]
Proposed spec patch

Fix failure of testsuite caused by missing fonts in buildroot.

Comment 1 Jaroslav Škarvada 2010-10-22 12:01:42 UTC
Forwarded upstream.

Comment 2 Jaroslav Škarvada 2010-10-26 08:46:35 UTC
Upstream bugzilla: http://graphviz.org/bugs/b2063.html

Comment 3 Jaroslav Škarvada 2011-01-06 23:30:14 UTC
Fixed all issues which can be easily fixed but the testsuite still needs to be improved by upstream.

Comment 4 Fedora Update System 2011-01-21 16:03:24 UTC
graphviz-2.26.3-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/graphviz-2.26.3-1.fc14

Comment 5 Fedora Update System 2011-01-21 16:05:04 UTC
graphviz-2.26.3-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/graphviz-2.26.3-1.fc13

Comment 6 Fedora Update System 2011-02-22 16:51:12 UTC
graphviz-2.26.3-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/graphviz-2.26.3-2.fc14

Comment 7 Fedora Update System 2011-02-22 16:59:09 UTC
graphviz-2.26.3-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/graphviz-2.26.3-2.fc13

Comment 8 Fedora Update System 2011-03-04 09:57:28 UTC
graphviz-2.26.3-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2011-03-04 10:04:50 UTC
graphviz-2.26.3-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.