Bug 645761
| Summary: | Review Request: django-threadedcomments - a simple yet flexible threaded commenting system for Django | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Domingo Becker <domingobecker> |
| Component: | Package Review | Assignee: | Gianluca Sforna <giallu> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, giallu, notting |
| Target Milestone: | --- | Flags: | giallu:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | django-threadedcomments-0.5.3-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-20 17:29:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 645752 | ||
|
Description
Domingo Becker
2010-10-22 12:18:17 UTC
Most of my comments in bug 645764 also apply here: * Full URL is needed on Source * License should be BSD * License Text should be included in the package * Summary should be shortened (A simple yet... is enough) * There are couple more files for the %doc section (Changelog.txt and contributors.txt) * Version advised in changlog does not match package * Did not check a mock build, but chances are Django is needed as BR: Updating fields for review, looks like you have been sponsored :) (In reply to comment #1) > Most of my comments in bug 645764 also apply here: > > * Full URL is needed on Source Fixed. > * License should be BSD Fixed. > * License Text should be included in the package Fixed. > * Summary should be shortened (A simple yet... is enough) Please, check it. > * There are couple more files for the %doc section (Changelog.txt and > contributors.txt) Fixed. > * Version advised in changlog does not match package Changelog seems to be outdated. I will communicate it upstream. > * Did not check a mock build, but chances are Django is needed as BR: Added as BuildRequires. Same spec and srpm urls as in first comment. Ok. This is mosty in a good shape. please fix these rpmlint complaints and I think I can approve it: django-threadedcomments.noarch: W: summary-not-capitalized C a simple yet flexible threaded commenting system for Django django-threadedcomments.noarch: E: description-line-too-long C django-threadedcomments is a simple yet flexible threaded commenting system for Django. django-threadedcomments.noarch: W: incoherent-version-in-changelog 1.1.4-1 ['0.5.3-1.fc14', '0.5.3-1'] django-threadedcomments.noarch: W: hidden-file-or-dir /usr/share/doc/django-threadedcomments-0.5.3/docs/._pinax.txt Always remember to run rpmlint both on source and binary packages, reviewers are going to do it anyway and ask you to fix warning/errors It's also easier for the reviewer if you always increment the release number at each iteration, e.g. you sould make a 0.5.3-2, adding a changelog line. Removed the warnings mentioned above. Bumped new release number. Spec URL: http://beckerde.fedorapeople.org/transifex/django-threadedcomments.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/django-threadedcomments-0.5.3-2.fc13.src.rpm Just one minor thing. The new doc section includes INSTALL.txt; since installation is covered by rpm we don't usually package those files. Anyway, I think we're done here. Full review: * Package name is correct * spec file name correct * spec file is legible and in english * License field is correct and acceptable in Fedora * License text is included in package * sources match upstream * macros used consistently * Builds correctly in mock for F14 * rpmlint is silent APPROVED New Package SCM Request ======================= Package Name: django-threadedcomments Short Description: A simple yet flexible threaded commenting system for Django Owners: beckerde Branches: f13 f14 el5 el6 InitialCC: glezos diegobz Git done (by process-git-requests). django-threadedcomments-0.5.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/django-threadedcomments-0.5.3-2.fc14 django-threadedcomments-0.5.3-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/django-threadedcomments-0.5.3-2.fc13 django-threadedcomments-0.5.3-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/django-threadedcomments-0.5.3-2.el5 django-threadedcomments-0.5.3-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-threadedcomments'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/django-threadedcomments-0.5.3-2.el5 django-threadedcomments-0.5.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. django-threadedcomments-0.5.3-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. django-threadedcomments-0.5.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |