Bug 646573
| Summary: | Review Request: rubygem-whiskey_disk - Ruby tool for embarrassingly fast deployments | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Stahnke <mastahnke> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-whiskey_disk-0.5.4-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-08 17:36:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Stahnke
2010-10-25 17:49:03 UTC
Some notes
* License
- License tag for this packge should be "MIT".
* %files
- The directory %geminstdir itself is not owned by any packages
! Enabling test
- From $ rake -P, for this gem "$ rake test" does some
test programs (it seems rubygem-bacon is needed).
Would you consider to enable %check and execute this?
! File name in %_bindir
- Maybe the name "wd" is too short for files under %_bindir
(to avoid file name space conflict). Would you contact the
upstream to make script name longer to something specific
to this gem? (not a blocker)
By the way I would appreciate it if you would review my review request (bug 646181) Hmm, wonder how I missed the license. I'll fix files. Tests, I'll see if I can fix it. I was getting jeweller errors, but I'd love to have them enabled. I don't think they are going to want to change wd to something else. I'll ask thought. I'll take your review also. Spoke with upstream. They basically said if nobody has taken /usr/bin/wd by now, then it's probably ok. They did say they take it under advisement. Enabled tests and added bacon, facon and rake to BR(check). Files should be fixed by claiming the %geminstdir in the main package. License tag updated. New SRPM: http://stahnma.fedorapeople.org/reviews/rubygem-whiskey_disk-0.5.3-2.fc15.src.rpm Approving. -------------------------------------------------------- This package (rubygem-whiskey_disk) is APPROVED by mtasaka -------------------------------------------------------- New Package SCM Request ======================= Package Name: rubygem-whiskey_disk Short Description: Ruby tool for embarrassingly fast deployments Owners: stahnma Branches: el5 el6 f13 f14 InitialCC: Git done (by process-git-requests). rubygem-whiskey_disk-0.5.3-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-whiskey_disk-0.5.3-1.fc13 rubygem-whiskey_disk-0.5.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-whiskey_disk-0.5.3-1.fc14 rubygem-whiskey_disk-0.5.3-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-whiskey_disk'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-whiskey_disk-0.5.3-1.fc13 Closing. rubygem-whiskey_disk-0.5.4-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-whiskey_disk-0.5.4-1.fc13 rubygem-whiskey_disk-0.5.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-whiskey_disk-0.5.4-1.fc14 rubygem-whiskey_disk-0.5.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-whiskey_disk-0.5.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |