Bug 646874
Summary: | Review Request: rubygem-sequel - database toolkit for ruby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alejandro_Perez <alejandro.perez.torres> |
Component: | Package Review | Assignee: | Guillermo Gómez <guillermo.gomez> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, guillermo.gomez, mtasaka, notting, steve.traylen |
Target Milestone: | --- | Flags: | guillermo.gomez:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-01-27 13:27:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Alejandro_Perez
2010-10-26 14:32:13 UTC
This is my first package, therefore I'm looking for a sponsor I'll take this one, mentoring Alejandro and coworking with Toshio as sponsor. 1. Please always include rpmlint output on your requests http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Filter obvious/useless warnings if too long (happens with yaml/rdoc files in sombre ruby packages) 2. Changelog, adjust according to release number. Avoid mistakes using rpmdev-bumpspec. Also for more than one change, break on several lines %changelog * Tue Oct 26 2010 Alejandro Pérez <aeperezt> - 3.16.0.3 - renamed spec file name, change from list of doc files to doc folder * Fri Oct 23 2010 Alejandro Pérez <aeperezt> - 3.16.0-3 %changelog * Tue Oct 26 2010 Alejandro Pérez <aeperezt> - 3.16.0.4 - Renamed spec file name - Change from list of doc files to doc folder * ... 3. koji builds fine for F14, F13 and F12. Besides this couple of little things... :-D 1. New change done to fix error on the change log new version set to 3.16.0-5 spec file at http://aeperezt.fedorapeople.org/rpmdev/rubygem-sequel.spec srpm file at http://aeperezt.fedorapeople.org/rpmdev/rubygem-sequel-3.16.0-5.fc14.src.rpm 2. rpmlint output for spec and srpm rpmlint -i rubygem-sequel.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -i ../SRPMS/rubygem-sequel-3.16.0-5.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks. Reviewed the License, fix it to MIT. 1 License, changed spec file at http://aeperezt.fedorapeople.org/rpmdev/rubygem-sequel.spec srpm file at http://aeperezt.fedorapeople.org/rpmdev/rubygem-sequel-3.16.0-6.fc14.src.rpm 2 rpmlint for spec and srpm file rpmlint -i rubygem-sequel.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -i ../SRPMS/rubygem-sequel-3.16.0-6.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # Package naming: OK # Spec file name: OK # License: OK # Spec written in en_US: OK # Spec file legible: OK # Sources matches upstream: OK # Compile/build: OK # BuildRequires: OK # Consistency using macros: OK # Large documentation files must go in a -doc subpackage: OK # koji builds fine for F12, F13 and F14 APPROVED New Package SCM Request ======================= Package Name: rubygem-sequel Short Description: Database toolkit for Ruby Owners: aeperezt Branches: F13 F14 el6 InitialCC: gomix Git done (by process-git-requests). Hi Alejandro, Would you consider creating an EPEL5 build of rubygem-sequel I just tried rebuilding the EPEL6 package and it builds with out modification, scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2735398 Steve. (p.s this ticket probably needs closing.) |