Bug 647063
| Summary: | Review Request: atool - Perl script to handle various archive formats | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre Carrier <prc> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-31 01:58:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre Carrier
2010-10-27 01:19:42 UTC
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2563115 fc14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2563132 I'll review it too (and will sponsor you). Unblocking FE-NEEDSPONSOR - I just sponsored pcarrier. I see the only issue - you didn't add COPYING as %doc (this is a MUST ifupstream provides licensing terms in its own file). So, please, mark COPYING as %doc and I'll continue. Updated. No release bump as this wasn't distributed yet. Thanks Peter! REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is not silent. However almost all its messages can be safely ignored
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/atool-0.37.0-1.fc12.noarch.rpm
atool.noarch: W: spelling-error Summary(en_US) perl -> Perl, peel, perk
atool.noarch: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
atool.noarch: W: spelling-error %description -l en_US bzip -> zip, blip, b zip
atool.noarch: W: spelling-error %description -l en_US lzop -> lop, loop, Lopez
atool.noarch: W: spelling-error %description -l en_US lzma -> lama, Lima, Lamaze
atool.noarch: W: spelling-error %description -l en_US pkzip -> pk zip, pk-zip, pipkin
atool.noarch: W: spelling-error %description -l en_US rar -> arr, ear, tar
atool.noarch: W: spelling-error %description -l en_US arj -> raj, ark, ar
atool.noarch: W: spelling-error %description -l en_US cpio -> CPI, Scipio, campion
atool.noarch: W: spelling-error %description -l en_US alzip -> al zip, al-zip, aliped
atool.noarch: W: file-not-utf8 /usr/share/doc/atool-0.37.0/NEWS
1 packages and 0 specfiles checked; 0 errors, 11 warnings.
sulaco ~/rpmbuild/SPECS:
Please, convert NEWS from iso-8859-1 to UTF-8.
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv2 or later).
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum atool-0.37.0.tar.gz*
5fa8b6481c67dcdb44956b061c30f0904aa420708a9f3ddc7c20fc4e0e4c215f atool-0.37.0.tar.gz
5fa8b6481c67dcdb44956b061c30f0904aa420708a9f3ddc7c20fc4e0e4c215f atool-0.37.0.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please, note that due to missing %clean section your package won't conform the guidelines on some old Fedora releases and EPEL 4 and 5 (not sure about 6). Also don't forget to convert NEWS to UTF-8.
APPROVED.
Correction made using iconv. I do not target Fedora 12-, nor EPEL5-. However if policies on EPEL6 do not match F13+ I'll probably adapt the relevant SPECs. Thank you for the approval :) New Package SCM Request ======================= Package Name: atool Short Description: Perl script to handle various archive formats Owners: pcarrier Branches: f14 el6 InitialCC: pcarrier Git done (by process-git-requests). |