Bug 647149
| Summary: | Review Request: perl-Test-Fatal - Incredibly simple helpers for testing code with exceptions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-Fatal-0.003-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-05 22:07:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 647124 | ||
| Bug Blocks: | |||
|
Description
Paul Howarth
2010-10-27 11:39:29 UTC
Upstream updated to 0.002. New SRPM: http://www.city-fan.org/~paul/extras/perl-Test-Fatal/perl-Test-Fatal-0.002-1.fc13.src.rpm Spec URL unchanged. Upstream updated to 0.003. New SRPM: http://www.city-fan.org/~paul/extras/perl-Test-Fatal/perl-Test-Fatal-0.003-1.fc13.src.rpm Spec URL unchanged. Try::Tiny is now updated to 0.07 in Rawhide, so this package can now be built for F15. Source file original. Ok. License verified from README. Ok. > Patch0: Test-Fatal-0.003-versions.patch TODO: Post the patch to upstream. > -use ExtUtils::MakeMaker 6.31; > +use ExtUtils::MakeMaker 6.17; TODO: Put the version to BuildRequires in spec file. This makes RPM backporting into old distribution easier. > - 'Test::More' => '0.96', > + 'Test::More' => '0.47', TODO: Put the version to BuildRequires in spec file. > BuildRequires: perl(Test::Pod) > $ grep -Hnr Test::Pod * > t/release-pod-syntax.t:12:eval "use Test::Pod 1.41"; > t/release-pod-syntax.t:13:plan skip_all => "Test::Pod 1.41 required for testing TODO: Put the version to BuildRequires in spec file. All tests pass. Ok. $ rpmlint perl-Test-Fatal.spec ../SRPMS/perl-Test-Fatal-0.003-1.fc15.src.rpm ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -pq -lv ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm drwxr-xr-x 2 root root 0 lis 4 17:08 /usr/share/doc/perl-Test-Fatal-0.003 -rw-r--r-- 1 root root 379 říj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/Changes -rw-r--r-- 1 root root 18258 říj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/LICENSE -rw-r--r-- 1 root root 324 říj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/README -rw-r--r-- 1 root root 3046 lis 4 17:08 /usr/share/man/man3/Test::Fatal.3pm.gz drwxr-xr-x 2 root root 0 lis 4 17:08 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 3355 lis 4 17:08 /usr/share/perl5/vendor_perl/Test/Fatal.pm File layout and permissions Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(strict) 1 perl(Try::Tiny) >= 0.07 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -pq --provides ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm | sort | uniq -c 1 perl(Test::Fatal) = 0.003 1 perl-Test-Fatal = 0.003-1.fc15 Binary dependencies Ok. Package is in line with Fedora and Perl packaging guidelines. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576674). Ok. Please consider correcting all `TODO' prefixed advises. Resolution: Package APPROVED. New Package CVS Request ======================= Package Name: perl-Test-Fatal Short Description: Incredibly simple helpers for testing code with exceptions Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-13 F-14 InitialCC: perl-sig >> Patch0: Test-Fatal-0.003-versions.patch >TODO: Post the patch to upstream. Done: https://rt.cpan.org/Public/Bug/Display.html?id=62699 >> -use ExtUtils::MakeMaker 6.31; >> +use ExtUtils::MakeMaker 6.17; >TODO: Put the version to BuildRequires in spec file. This makes RPM backporting into old distribution easier. Not really necessary: this version requirement is met by all current releases including EL-4. >> - 'Test::More' => '0.96', >> + 'Test::More' => '0.47', >TODO: Put the version to BuildRequires in spec file. Again, this requirement is met by all current releases. >> BuildRequires: perl(Test::Pod) >> $ grep -Hnr Test::Pod * >> t/release-pod-syntax.t:12:eval "use Test::Pod 1.41"; >> t/release-pod-syntax.t:13:plan skip_all => "Test::Pod 1.41 required for testing >TODO: Put the version to BuildRequires in spec file. Doing that would prevent builds on older releases purely because we couldn't check the POD syntax during the build, so I don't think that's a good idea. Thanks for the review Petr. Git done (by process-git-requests). perl-Test-Fatal-0.003-1.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.el4 perl-Test-Fatal-0.003-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.el5 perl-Test-Fatal-0.003-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.fc13 perl-Test-Fatal-0.003-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.fc14 perl-Test-Fatal-0.003-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-Fatal-0.003-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-Fatal-0.003-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-Fatal-0.003-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. Built and released in all branches now. |