Bug 647501

Description of problem:

The org.rhq.core.gui.table.renderer.SortableColumnHeaderRenderer is extending com.sun.faces.renderkit.html_basic.CommandLinkRenderer;

Because of this it is dependant on the Sun JSF Implementation, meaning it cannot run on Myfaces or other JSF implementations.

http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=blob;f=modules/core/gui/src/main/java/org/rhq/core/gui/table/renderer/SortableColumnHeaderRenderer.java;h=1f80312c6946a8abd06f40dd83ca8f835594f4f0;hb=HEAD

The rhq code should delegate to a JSF renderer if it needs to call its functionality instead of extending it.  I can't find exact article I was looking for, but [1] talks a little bit about it.

[1] http://java.sun.com/developer/technicalArticles/J2EE/jsf_renderers/

The fix would be to get the renderer for (family=javax.faces.Command, rendererType=javax.faces.Link).  Then invoke it. 

If you need most of the particular renderers functionality, you could create a Base class that extends javax.faces.render.Renderer, have it take in the family and rendererType.  Then implement all of the Renderer methods and inside the methods have them call getRenderer(family,renderType) and invoke the method.  Such as the example below: 

public ExtendJSFRenderer extends javax.faces.render.Renderer
{
 public ExtendJSFRenderer(String family, String rendererType)
 {
  this.family = family;
  this.rendererType = rendererType;
 }

protected Renderer getRenderer ()
{
    FacesContext context = FacesContext.getCurrentInstance ();
    return getRenderer ( context );
}

protected Renderer getRenderer ( FacesContext context )
{
    return context.getRenderKit().getRenderer ( this.family, this.rendererType );
}
public void decode ( FacesContext context, UIComponent component )
{
    getRenderer ( context ).decode ( context, component );
}
public boolean getRendersChildren ()
{
 return getRenderer ().getRendersChildren ();
}
...
}


If you created this base class ExtendJSFRenderer, then the only change to the rhq code would be 

public SortableColumnHeaderRenderer()
{
  super ( "javax.faces.Command", "javax.faces.Link" );
}



How reproducible:


Steps to Reproduce:
1.  Remove the Sun JSF implementation and put the MyFaces Implementation in and it will get a ClassNotFound. 

  
Actual results:
ClassNotFound com.sun.faces.renderkit.html_basic.CommandLinkRenderer;

Expected results:
No ClassNotFound