Bug 647789
| Summary: | wrong return code if related daemon stopped unexpectedly | ||
|---|---|---|---|
| Product: | Red Hat Enterprise MRG | Reporter: | Lubos Trilety <ltrilety> |
| Component: | condor | Assignee: | Matthew Farrellee <matt> |
| Status: | CLOSED ERRATA | QA Contact: | Tomas Rusnak <trusnak> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 1.3 | CC: | iboverma, ltoscano, matt, trusnak |
| Target Milestone: | 2.0 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | condor-7.5.6-0.1 | Doc Type: | Bug Fix |
| Doc Text: |
C: Some command-line tools would not consistently report errors via their return code.
C: Scripting the tools can be more complicated than is necessary.
F: A number of tools (mentioned in BZ) were updated to report errors when connection problems occurred.
R: The tools are now easier to script as they report errors when they have connection problems.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-23 15:41:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 693778 | ||
|
Description
Lubos Trilety
2010-10-29 13:17:52 UTC
Or... $ echo "<1.2.3.4:1234>" > dummy_master_address $ _CONDOR_MASTER_ADDRESS_FILE=$PWD/dummy_master_address condor_off Can't connect to local master $ echo $? 0 The condor_master -n appears to just be a way to get a LOG/.master_address file written and not cleaned up when the master exits. Bad... $ for t in condor_on condor_reconfig condor_restart condor_off; do $t; echo $?; done Can't connect to local master 0 Can't connect to local master 0 Can't connect to local master 0 Can't connect to local master 0 Good... $ for t in condor_on condor_reconfig condor_restart condor_off; do $t; echo $?; done Can't connect to local master 1 Can't connect to local master 1 Can't connect to local master 1 Can't connect to local master 1 Upstream at https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=1895 Fixed for 7.5.6. commit 6bac22ec1623d39e72e0310ef9485586d1d2e112 Author: Matthew Farrellee <matt@redhat> Date: Thu Feb 3 15:56:08 2011 -0500 Report errors via tool exit codes when talking to local master, #1895 diff --git a/src/condor_tools/tool.cpp b/src/condor_tools/tool.cpp
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
C: Some command-line tools would not consistently report errors via their return code.
C: Scripting the tools can be more complicated than is necessary.
F: A number of tools (mentioned in BZ) were updated to report errors when connection problems occurred.
R: The tools are now easier to script as they report errors when they have connection problems.
Reproduced on x86_64/RHEL5 with: $CondorVersion: 7.4.5 Feb 4 2011 BuildID: RH-7.4.5-0.8.el5 PRE-RELEASE $ $CondorPlatform: X86_64-LINUX_RHEL5 # condor_off; echo $? Can't connect to local master 0 # condor_vacate; echo $? Can't connect to local startd 0 # condor_off; echo $? Can't connect to local master 0 # condor_on; echo $? Can't connect to local master 0 # condor_reconfig; echo $? Can't connect to local master 0 # condor_restart ; echo $? Can't connect to local master 0 Retested over all supported platforms - x86,x96_64/RHEL5,RHEL6 with:
condor-7.6.1-0.4
# condor_off; echo $?
Can't find address for local master
Perhaps you need to query another pool.
1
# condor_vacate; echo $?
Can't find address for local startd
Perhaps you need to query another pool.
1
# condor_off; echo $?
Can't find address for local master
Perhaps you need to query another pool.
1
# condor_on; echo $?
Can't find address for local master
Perhaps you need to query another pool.
1
# condor_reconfig; echo $?
Can't find address for local master
Perhaps you need to query another pool.
1
# condor_restart ; echo $?
Can't find address for local master
Perhaps you need to query another pool.
1
All tools returns correct error code, now.
>>> VERIFIED
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHEA-2011-0889.html |