Bug 649356
| Summary: | Review Request: luakit - Micro-browser framework based on WebKit and GTK+ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre Carrier <prc> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | luakit-2010.09.24-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-09 22:04:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre Carrier
2010-11-03 15:46:35 UTC
I'll review it I'd rather assume right away that upstream releases every month, and I do not believe backporting bug fixes will be a viable solution. I will be discussing with upstream our ability to document changes to the Lua API within upstream versions. If needed, I will consider maintaining a API deprecation "buffer" between version bumps in Fedora releases. It is more than possible that upstream versions will be skipped; this will again involve discussions with upstream on a case-by-case basis. s/within/between/ Hello Peter, Requested modifications applied. Your messages got lost in the warp. Thanks, -- Pierre Latest koji scratch build for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2590022 REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is NOT silent work ~: rpmlint ~/Desktop/luakit-* luakit.src: W: spelling-error %description -l en_US behaviour -> behavior, behave, behalves ^^^ false positive luakit.src:35: W: macro-in-comment %doc ^^^ may be safely omitted luakit.src: W: no-buildroot-tag ^^^ ok for recent Fedora versions but may produce issues in EPEL. luakit.src: W: invalid-url Source0: luakit-2010.09.24.tar.gz ^^^ Ok, for github's projects. luakit.x86_64: W: spelling-error %description -l en_US behaviour -> behavior, behave, behalves ^^^ false positive luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/theme.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/modes.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/globals.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/binds.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/window.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/webview.lua luakit.x86_64: E: executable-marked-as-config-file /etc/xdg/luakit/rc.lua ^^^ please, comment this - should these files be +x and/or should ther be really marked as %config luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/session.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/theme.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/modes.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/lousy/init.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/go_next_prev.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/lousy/theme.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/globals.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/bookmarks.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/lousy/util.lua luakit.x86_64: E: script-without-shebang /usr/share/applications/luakit.desktop luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/binds.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/go_up.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/lousy/mode.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/formfiller.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/follow_selected.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/window.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/webview.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/follow.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/lousy/bind.lua luakit.x86_64: E: script-without-shebang /etc/xdg/luakit/rc.lua luakit.x86_64: E: script-without-shebang /usr/share/luakit/lib/go_input.lua 3 packages and 0 specfiles checked; 28 errors, 5 warnings. work ~: ^^^ these files are marked as +x but no shebang was added. Could you, please explain this - should they really be marked as executable? + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum mason-larobina-luakit-2010.09.24-0-gb9d8591.tar.gz luakit-2010.09.24.tar.gz 21629e4de89893759852f16807172a56dc550d1e1654d4e106cf9378b387cd41 mason-larobina-luakit-2010.09.24-0-gb9d8591.tar.gz 21629e4de89893759852f16807172a56dc550d1e1654d4e106cf9378b387cd41 luakit-2010.09.24.tar.gz sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji links above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. + The package includes a %{name}.desktop file, and this file is properly checked with desktop-file-validate in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok, this package is APPROVED New Package SCM Request ======================= Package Name: luakit Short Description: Micro-browser framework based on WebKit and GTK+ Owners: pcarrier Branches: f14 el6 InitialCC: Git done (by process-git-requests). luakit-2010.09.24-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/luakit-2010.09.24-1.fc14 luakit-2010.09.24-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |