Bug 649425

Extended description.

With this application one could rip CDs. You could, before ripping, specify track names, artist (or artistes), year, album. There several ripping presets including audio format, track naming, files location and etc, but you could easy create your own, based on existing or bright new with your own encoder if you have on (you could select what will be the default one). All encoding option easy to specify. If you have several drivers, dropping menu will help you to select right one. Sure, there is a real-time jobs watcher.

Review
=======
Good:

- rpmlint checks return:
kaudiocreator.x86_64: W: no-manual-page-for-binary kaudiocreator

Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on F-14 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file OK

== Notes ==
* BuildRequires:  gtk2 seems wrong. I did a scratch build without it (http://koji.fedoraproject.org/koji/taskinfo?taskID=2639728) and it built fine (as expected). You should remove it from your final package.

* %clean is unnecessary in active Fedora targets, see: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean (it is still needed if you need this package for EPEL)
* BuildRoot is unnecessary in active Fedora targets, see: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (it is still needed if you need this package for EPEL)
* It is no longer necessary to delete the buildroot as the first step of %install in active Fedora targets. It is still needed if you need this package for EPEL.

These items are relatively minor, so I won't hold the review up on them.
APPROVED.

(If you could do a review on 656010, I would appreciate it, shouldn't be too rough.)

(In reply to comment #2)
> == Notes ==
> * BuildRequires:  gtk2 seems wrong. I did a scratch build without it
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=2639728) and it built fine
> (as expected). You should remove it from your final package.

Ah, gtk2 is dependece of some other package. It does not need to be metioned explicitly.


> * %clean is unnecessary in active Fedora targets, see:
> https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean (it is still
> needed if you need this package for EPEL)

This and following are from F12 wich was not EOL at submiting this review.

Spec and srpm updated.

New Package SCM Request
=======================
Package Name: kaudiocreator
Short Description: Program for ripping and encoding Audio-CDs
Owners: krege
Branches: f13 f14
InitialCC:

Git done (by process-git-requests).

Thanks everybody.

kaudiocreator-1.2.90-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kaudiocreator-1.2.90-2.fc14

kaudiocreator-1.2.90-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/kaudiocreator-1.2.90-2.fc13

kaudiocreator-1.2.90-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

kaudiocreator-1.2.90-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: kaudiocreator
New Branches: el6
Owners: krege


See also rhbz #912934

Git done (by process-git-requests).