Bug 650165

Description of problem:
From satellite_tools/disk_dumper/dumper.py:

_query_get_package_ids_by_date_limits = rhnSQL.Statement("""
        select package_id
          from rhnPackage rp, rhnChannelPackage rcp
         where rcp.channel_id = :channel_id
         and rcp.package_id = rp.id
         and (rcp.modified >= TO_Date(:lower_limit, 'YYYYMMDDHH24MISS')
              or rp.last_modified >= TO_Date(:lower_limit, 'YYYYMMDDHH24MISS')
             )
         and (rcp.modified <= TO_Date(:upper_limit, 'YYYYMMDDHH24MISS')
              or rp.last_modified <= TO_Date(:upper_limit, 'YYYYMMDDHH24MISS')
             )
     """)

rhnPackage.last_modified values are (ordinarilly) being populated during
satellite-sync w/ RHN and represent the time the package was modified
on RHN side (i.e. it is a value we take from RHN and store it so as it is).

rhnChannelPackage.modified values are being filed during satellite-sync
and are set to sysdate of the sync (they represent the moment when the
particular package became part of that particular channel, which is
the moment of the sync).

For a particular package to become part of an incremental dump (defined by
:lower_limit and :upper_limit placeholders), either of rhnPackage.last_modified
rhnChannelPackage.modified has to fit into the interval specified.

Imagine you've just synced a RHEL-5-Server channel from RHN (i.e.
rhnChannelPackage.modified values are very fresh) and want to export its
content from recent past (for example starting week ago, finishing 2 days ago).
Your situation would look like:

lower_limit < upper_limit < all rhnChannelPackage.modified values

Since most of the rhnPackage.last_modified values will be older than
your specified lower_limit (the channel content is simply much older),

the

(rcp.modified >= TO_Date(:lower_limit, 'YYYYMMDDHH24MISS')
 or rp.last_modified >= TO_Date(:lower_limit, 'YYYYMMDDHH24MISS')
) and
(rcp.modified <= TO_Date(:upper_limit, 'YYYYMMDDHH24MISS')
 or rp.last_modified <= TO_Date(:upper_limit, 'YYYYMMDDHH24MISS')
)

condition will be true for most of the packages contained in the channel
and your incremental dump will contain pretty much the whole channel.

I believe rhn-satellite-exporter needs to be able to export the incremental
channel content based on rhnChannelPackage.modified values, and based on
rhnPackage.last_modified values but definitely must not 'OR' the two values.

In another words, when creating incremental content, you need to be able
to specify, whether you wish to select the packages based on the date
they were born in RHN or they were actually synced to your Satellite.


Version-Release number of selected component (if applicable):
spacewalk-backend-1.2.13-11

How reproducible:
Always

Steps to Reproduce:
1. New Satellite 5.4 installation, sync some content from RHN
2. Create incremental export starting 7 days ago, finishing 2 days ago
3. Check the created export
  
Actual results:
The export contains whole channel.

Expected results:
You need to be able to specify what date you want to select the packages
for the export.

Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=589524