Bug 650712
| Summary: | Review Request: xcm - X Color Management tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-21 08:47:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Chauvet (kwizart)
2010-11-07 20:56:44 UTC
libXcm-0.3.0 isn't yet in f14 buildroot, so it will only work for f15. I will take this. Nicolas, I would appreciate it if you would have time to review my review ticket (bug 654862) Some comments:
* No longer needed lines
- On Fedora, the following lines are no longer needed.
- BuildRoot line:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
- %clean section
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* Build failure
- Build failed on dist-f14-updates-candidate
http://koji.fedoraproject.org/koji/taskinfo?taskID=2619152
Looks line BR: libxml2-devel is needed
* Usability
-----------------------------------------------------
$ env LANG=C xcmevents
libXcm basied X11 colour management system events observer
(c) 2009-2010 - Kai-Uwe Behrmann License: MIT
atom: "_NET_COLOR_PROFILES": 731
atom: "_NET_COLOR_TARGET": 732
atom: "_NET_COLOR_MANAGEMENT": 733
atom: "_NET_COLOR_REGIONS": 734
atom: "_NET_COLOR_DESKTOP": 735 0
root window ID: 167
WARNINGrunning "oyranos-monitor -lc":
sh: oyranos-monitor: command not found
-----------------------------------------------------
- Does this mean that some additional package should be added
as "Requires"?
Do you include update-testing package along with dist-f14-updates-candidate ? oyranos-devel 0.1.12 was there and it has a fixed to avoid the usage of uneeded link flags (was included upstream git recently). This last has reached updates stable so it should work now. The oyranos package is indeed missing at runtime. (added in my local copy). (In reply to comment #4) > Do you include update-testing package along with dist-f14-updates-candidate ? - No, because update-testing packages are not in F14 buildroot (unless the packages have override tag). > oyranos-devel 0.1.12 was there and it has a fixed to avoid the usage of uneeded > link flags (was included upstream git recently). > This last has reached updates stable so it should work now. - It seems. http://koji.fedoraproject.org/koji/taskinfo?taskID=2635304 > The oyranos package is indeed missing at runtime. (added in my local copy). - Okay. Please upload the next one. ping? Spec URL: http://kwizart.fedorapeople.org/review/xcm.spec SRPM URL: http://kwizart.fedorapeople.org/review/xcm-0.3.0-2.fc14.src.rpm Description: X Color Management tools Changelog: Add Requires oyranos Please also consider to address the following. (In reply to comment #3) > Some comments: > > * No longer needed lines > - On Fedora, the following lines are no longer needed. > - BuildRoot line: > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > - %clean section > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > ------------------------------------------------------- This package (xcm) is APPROVED by mtasaka ------------------------------------------------------- New Package SCM Request ======================= Package Name: xcm Short Description: X Color Management tools Owners: kwizart Branches: devel f14 f13 el6 InitialCC: Git done (by process-git-requests). |