Bug 650717
| Summary: | Review Request: PolicyKit-olpc - OLPC-specific PolicyKit overrides | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Drake <dsd> |
| Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pbrobinson |
| Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | PolicyKit-olpc-1.4-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-09 20:59:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daniel Drake
2010-11-07 21:19:06 UTC
I'll review this one. Original review https://bugzilla.redhat.com/show_bug.cgi?id=454329 Looks fine but except for the one rpmlint warning although not a blocker. APPROVED.
+ rpmlint output
rpmlint PolicyKit-olpc-1.4-1.fc14.src.rpm PolicyKit-olpc-1.4-1.fc14.noarch.rpm PolicyKit-olpc.spec
PolicyKit-olpc.src: W: strange-permission PolicyKit-olpc-1.4.tar.gz 0444L
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
5cad081bb55d925671cf9881433b781f PolicyKit-olpc-1.4.tar.gz
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ Permissions on files must be set properly
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
n/a Package should have man files
Thanks Peter! Admins: this once-broken package is now finally fixed and ready for use once again. Please add a F14 branch, and unblock it from being built in rawhide. Package Change Request ====================== Package Name: PolicyKit-olpc New Branches: F14 Unblock Branches: rawhide Git done (by process-git-requests). Untired and branch added. If there is a next time please include the owner in the request: you can use the web interface to take ownership now: https://admin.fedoraproject.org/pkgdb/acls/name/PolicyKit-olpc Thanks. I will do that. Unfortunately I still can't build this in rawhide or F14. Please could you investigate? 2655752 build (dist-rawhide, /PolicyKit-olpc:e180650d86e0441c8171e0050c19fb3b1b0b11bb): open (x86-03.phx2.fedoraproject.org) -> FAILED: BuildError: package PolicyKit-olpc is blocked for tag dist-f15 2655760 build (dist-f14-updates-candidate, /PolicyKit-olpc:e180650d86e0441c8171e0050c19fb3b1b0b11bb): open (x86-13.phx2.fedoraproject.org) -> FAILED: BuildError: package PolicyKit-olpc is blocked for tag dist-f14-updates-candidate Package Change Request ====================== Package Name: PolicyKit-olpc Unblock all tags F14 and onwards Unblocking packages from tags is not an SCM operation; I'm afraid I can't do what you are requesting. You probably need to file a ticket with release engineering: https://fedorahosted.org/rel-eng/ Requested: https://fedorahosted.org/rel-eng/ticket/4296 PolicyKit-olpc-1.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/PolicyKit-olpc-1.4-1.fc14 PolicyKit-olpc-1.4-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update PolicyKit-olpc'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/PolicyKit-olpc-1.4-1.fc14 PolicyKit-olpc-1.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |