Bug 650727
| Summary: | Please don't remove gtksourceviewmmconfig.h. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzesimir Nowak <qdlacz> |
| Component: | gtksourceviewmm | Assignee: | Haïkel Guémar <karlthered> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 13 | CC: | karlthered |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | gtksourceviewmm-2.10.1-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-17 23:17:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I believe that gtksourceviewmmconfig.h is an internal header so it should not be distributed alongside public headers. So what's the rationale for providing it ? Naah, it is not internal header in the same way like gtkmmconfig.h or glibmmconfig.h are not internal headers and they are distributed. These headers define some stuff like whether to disable deprecated stuff, version numbers, compiler abilities with regard to template handling and so on. And some of these defines are used in public headers.
If you are curious - see /usr/lib{64}/glibmm-2.4/include/glibmmconfig.h, which is distributed with glibmm24-devel.
The only cause that software using gtksourceviewmm (like nemiver) even compiled is that I forgot to add '#include <gtksourceviewmmconfig.h>' in sourceview.h, sourceiter.h and gtksourceviewmm.h, so preprocessor didn't look for nonexistent header. Which I fixed upstream.
Ok, i'll fix this by the next build for F13+ and it will be backported to F12 before EOL. Thanks for reporting this issue. gtksourceviewmm-2.10.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gtksourceviewmm-2.10.1-1.fc14 gtksourceviewmm-2.10.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/gtksourceviewmm-2.10.1-1.fc13 gtksourceviewmm-2.10.1-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gtksourceviewmm'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/gtksourceviewmm-2.10.1-1.fc14 gtksourceviewmm-2.10.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. gtksourceviewmm-2.10.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: When package is being build, one line in spec file causes gtksourceviewmmconfig.h to be removed instead of being included to devel package. Version-Release number of selected component (if applicable): gtksourceviewmm-2.10.0-1 How reproducible: Just install devel package and notice, that there is no config file. Additional info: The culprit is line 61. If I were this package maintainer I would just remove that and add a line to %files devel: %{_libdir}/gtksourceviewmm-2.0 Oh, and by the way - there is 2.10.1 version available.