Bug 651584
| Summary: | GFS2: BUG_ON kernel panic in gfs2_glock_hold on 2.6.18-226 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Steve Whitehouse <swhiteho> |
| Component: | kernel | Assignee: | Robert Peterson <rpeterso> |
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 6.1 | CC: | adas, adrew, anton, bmarzins, bmr, bturner, cww, dhoward, John.Hadad, jplans, nikb321, rpeterso, sbradley, swhiteho |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-2.6.32-130.el6 | Doc Type: | Bug Fix |
| Doc Text: |
Kernel panic could occur when the gfs2_glock_hold function was called within the gfs2_process_unlinked_inode function. This was due to the fact that gfs2_glock_hold was being called without a reference already held on the inode in question. This update, resolves this problem by changing the order in which it acquires references to match that of the NFS code; thus, kernel panic no longer occurs.
|
Story Points: | --- |
| Clone Of: | 643165 | Environment: | |
| Last Closed: | 2011-05-19 12:51:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 643165, 689943, 696535 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Comment 2
Steve Whitehouse
2010-11-09 20:53:06 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 469149 [details]
Fix which needs to be added to the main patch
Created attachment 469336 [details]
RHEL6 port of the original patch, including the one liner fix
Not tested yet, but here is the RHEL6 port of the rhel5/upstream patch including the one liner bug fix.
Created attachment 477543 [details]
modified patch that applies cleanly and compiles
http://porkchop.devel.redhat.com/brewroot/packages/kernel/2.6.32/114.el6.gfs2abhi.001/ This is a rhel6 build with the above patch included Note that this patch needs to have Bob's fix for bug #656032 merged into it. *** Bug 688729 has been marked as a duplicate of this bug. *** Might as well just use this one bz, also making a note that we need to add the bug #689943 fix in as well. Created attachment 488510 [details]
Integrated patch
This patch encompasses all the patches for 656032, crosswritten
to the RHEL6 gfs2 code. This is the one I intend to post to
rhkernel-list. I've done some basic functionality testing but
it could stand better testing in a clustered environment. At
this point, I don't have enough rhel6 boxes clustered to test
it.
Patch(es) available on kernel-2.6.32-130.el6 I verified that patches are included but I have not been able to devise a test case which reproduces the original report on RHEL 6.0.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Kernel panic could occur when the gfs2_glock_hold function was called within the gfs2_process_unlinked_inode function. This was due to the fact that gfs2_glock_hold was being called without a reference already held on the inode in question. This update, resolves this problem by changing the order in which it acquires references to match that of the NFS code; thus, kernel panic no longer occurs.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0542.html |