Bug 651789

Summary:	rhn-channel should report error when adding/removing wrong channel
Product:	Red Hat Enterprise Linux 6	Reporter:	Petr Sklenar <psklenar>
Component:	rhn-client-tools	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED ERRATA	QA Contact:	Martin Minar <mminar>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0	CC:	jhutar, mkoci, mminar, msuchy
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rhn-client-tools-1.0.0-44	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	651790 670214 670216 (view as bug list)		Environment:
Last Closed:	2011-05-19 13:05:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	670214, 670216
Bug Blocks:	582655, 651790, 715145

Comment 2 Miroslav Suchý 2011-01-17 15:15:58 UTC

This is more difficult then it look.

First. spacewalk-channel does not read returned code. Let solve it here.
Let define return code:
0  - everything is OK, channel is added/removed
1  - some error, channel is *not* added/removed
I will track client changes in this BZ.

Second. rhnParent always send return code 0. No matter what happen there.
So we have to do some change in both RHN Satellite and RHN hosted.

I will clone this BZ to both RHN Satellite and RHN hosted to track the change in server parts.

Comment 3 Miroslav Suchý 2011-01-17 15:55:11 UTC

Fixed in spacewalk.git as commit ca2b95ea966d7a1f8efb56fd2569effed9e778d0

Comment 4 Miroslav Suchý 2011-01-17 16:08:12 UTC

cherry picked to satellite.git as commit 5189ecd9aa5a1cdc8540d146416543e6959b2bac

Comment 7 Miroslav Suchý 2011-02-24 10:48:57 UTC

I could not reproduce, flipping back to ON_QA

Comment 9 Miroslav Suchý 2011-02-24 16:26:07 UTC

This is problem in backend handler. If there is no exception in code (i.e. one should be raised if you use name, which does not exist) there is simple
 return 0
So I have no chance to raise error on client.

If you use non existend name. E.g foo, you will get:
Error Message:
    Channel foo does not exist?

I will clone this BZ to RHN Satellite. Please test it without the problem in #8

Comment 10 Miroslav Suchý 2011-02-24 16:27:47 UTC

Argh, I already created them in past. 
See #670214 #670216.

Comment 11 Martin Minar 2011-02-25 09:05:44 UTC

Verified with rhn-client-tools-1.0.0-50.el6.noarch

Comment 12 errata-xmlrpc 2011-05-19 13:05:17 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0565.html