Bug 651815
| Summary: | meld should require 'patch' | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | pankaj pandey <pankaj86> |
| Component: | meld | Assignee: | Dominic Hopf <dmaphy> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 14 | CC: | bdpepple, erikina, gilboad, rpm, sandro.bonazzola |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-19 18:11:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This could be keyworded EasyFix, just adding patch to Requires. Is anybody still maintaining meld? http://fedoraproject.org/wiki/PackageMaintainers/Policy/NonResponsiveMaintainers Is anybody still maintaining meld? This is a very minor issue and the meld package is really very useful to me please don't orphan this package even if the maintainer is currently non-responsive. Thanks This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. *** Bug 657515 has been marked as a duplicate of this bug. *** *** Bug 627251 has been marked as a duplicate of this bug. *** *** Bug 606987 has been marked as a duplicate of this bug. *** Meld is still maintained, yes. Is it possible for you to check if the issue is still reproducible with the new meld 1.5.1? The package can be obtained here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3007032 Thanks for the fix and the new build. This one does install patch as a dependency, so the issue is fixed and this bug can be closed i suppose. Thanks very much for the feedback and the testing. :) |
Description of problem: Some functionality (visual two-pane diff of files in version control (hg)) of meld is unavailable if patch is not installed Version-Release number of selected component (if applicable): meld-1.3.2-1.fc14.noarch Steps to Reproduce: 1. install meld, remove patch 2. create a mercurial working copy (repo), edit some files 3. cd to the directory and run the command 'meld .' 4. local modified files are displayed in meld window 5. double click on any locally modified text file (colored red) Actual results: See the terminal window, following error message is shown: Traceback (most recent call last): File "/usr/share/meld/meld/task.py", line 130, in iteration ret = task() File "/usr/share/meld/meld/vcview.py", line 362, in run_diff_iter self.show_patch(prefix, patch) File "/usr/share/meld/meld/vcview.py", line 500, in show_patch if misc.write_pipe(patchcmd, patch) == 0: File "/usr/share/meld/meld/misc.py", line 242, in write_pipe proc = subprocess.Popen(command, stdin=subprocess.PIPE, stdout=subprocess.PIPE) File "/usr/lib64/python2.7/subprocess.py", line 672, in __init__ errread, errwrite) File "/usr/lib64/python2.7/subprocess.py", line 1201, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory Expected results: A visual two-pane diff of the file is shown in a new tab. It can be easily checked by installing 'patch' Additional info: The 'command' variable in /usr/share/meld/meld/misc.py:242 in above stacktrace is: ['patch', '--strip=1', '--reverse', '--directory=/tmp/tmptnY5qf-meld'] which led me to discover that 'patch' is required but not installed.