Bug 651858

Summary:	rhn-channel: tracebacks at various options combination
Product:	Red Hat Enterprise Linux 5	Reporter:	Petr Sklenar <psklenar>
Component:	rhn-client-tools	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED ERRATA	QA Contact:	Martin Minar <mminar>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5	CC:	jhutar, mkoci, mminar, msuchy, slukasik
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rhn-client-tools-0.4.20-52.el5	Doc Type:	Bug Fix
Doc Text:	When used with an incorrect option combination, the rhn-channel program failed with a traceback report.The report has been replaced by a simple, informative error message.	Story Points:	---
Clone Of:	651857	Environment:
Last Closed:	2011-07-21 07:08:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	651857
Bug Blocks:	634097

Description Petr Sklenar 2010-11-10 13:38:54 UTC

+++ This bug was initially created as a clone of Bug #651857 +++

Description of problem:
rhn-channel: tracebacks at various options combination


Version-Release number of selected component (if applicable):
rhel5: rhn-setup-0.4.20-45.el5
rhel6: rhn-setup-1.0.0-38.el6.noarch


How reproducible:
always

Steps to Reproduce:
1. `rhn-channel -u username -p password -c my-child-channel`

Actual results:

Traceback (most recent call last):
  File "/usr/sbin/rhn-channel", line 92, in ?
    main()
  File "/usr/sbin/rhn-channel", line 86, in main
    s = rhnserver.RhnServer()
NameError: global name 'rhnserver' is not defined

Expected results:
it should write smth like: "specify --add or --remove"


2. missing channel name after options -a and -r
`rhn-channel -u username -p password -a`
OR
`rhn-channel -u username -p password -r`

actual result:
Traceback (most recent call last):
  File "/usr/sbin/rhn-channel", line 92, in ?
    main()
  File "/usr/sbin/rhn-channel", line 74, in main
    subscribeChannels(OPTIONS.channel, OPTIONS.user, OPTIONS.password)
  File "/usr/share/rhn/up2date_client/rhnChannel.py", line 143, in subscribeChannels
    passwd)
  File "/usr/share/rhn/up2date_client/rhnserver.py", line 50, in __call__
    return rpcServer.doCall(method, *args, **kwargs)
  File "/usr/share/rhn/up2date_client/rpcServer.py", line 204, in doCall
    ret = method(*args, **kwargs)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1096, in __call__
    return self.__send(self.__name, args)
  File "/usr/share/rhn/up2date_client/rpcServer.py", line 38, in _request1
    ret = self._request(methodname, params)
  File "/usr/lib/python2.4/site-packages/rhn/rpclib.py", line 350, in _request
    request = self._req_body(params, methodname)
  File "/usr/lib/python2.4/site-packages/rhn/rpclib.py", line 231, in _req_body
    return xmlrpclib.dumps(params, methodname, encoding=self._encoding)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 1029, in dumps
    data = m.dumps(params)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 603, in dumps
    dump(v, write)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 615, in __dump
    f(self, value, write)
  File "/usr/lib64/python2.4/xmlrpclib.py", line 619, in dump_nil
    raise TypeError, "cannot marshal None unless allow_none is enabled"
TypeError: cannot marshal None unless allow_none is enabled

Expected results:
nice message, smth like:
ERROR: these arguments make no sense in this context (try --help)




Additional info:

Comment 1 Miroslav Suchý 2011-03-15 14:13:49 UTC

cherry picked to svn as rev. 201759.

Comment 4 Miroslav Suchý 2011-04-06 07:48:53 UTC

This is due rev. 201760 from BZ 651790.  I'm flipping this one back to ON_QA and marking 651790 as FAIL_QA

Comment 6 Miroslav Suchý 2011-04-07 09:04:09 UTC

Fixed in rev. 202420.

Comment 8 Eliska Slobodova 2011-06-29 11:57:30 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When used with an incorrect option combination, the rhn-channel program failed with a traceback report.The report has been replaced by a simple, informative error message.

Comment 9 errata-xmlrpc 2011-07-21 07:08:30 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0997.html