Bug 651862

Summary:	Review Request: php-jpgraph - Most powerful PHP driven charts
Product:	[Fedora] Fedora	Reporter:	Jeffrey Ness <jness>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora, fedora-package-review, giallu, notting, pahan, terje.rosten
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-11-11 20:05:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeffrey Ness 2010-11-10 13:55:06 UTC

Spec URL: http://flip-edesign.com/source/php-jpgraph/php-jpgraph.spec
SRPM URL: http://flip-edesign.com/source/php-jpgraph/php-jpgraph-3.5-0b1.src.rpm
Description: Most powerful PHP driven charts

--

One thing I was informed about was the 'Deja Vu fonts' being included in the Source, however as the QPL states this package needs to be in unmodified form:

-- QPL snippet --
2. You may copy and distribute the Software in unmodified form provided that the entire package, including - but not restricted to - copyright, trademark notices and disclaimers, as released by the initial developer of the Software, is distributed.
--

Below is the rpmlint for this package:

$ rpmlint /usr/src/redhat/SRPMS/php-jpgraph-3.5-0b1.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

--

Below you will find a successful build on the Fedora Build-System:

$ koji build --scratch dist-5E-epel /usr/src/redhat/SRPMS/php-jpgraph-3.5-0b1.src.rpm 
Uploading srpm: /usr/src/redhat/SRPMS/php-jpgraph-3.5-0b1.src.rpm
[====================================] 100% 00:00:36  12.64 MiB 353.97 KiB/sec
Created task: 2592847
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2592847
Watching tasks (this may be safely interrupted)...
2592847 build (dist-5E-epel, php-jpgraph-3.5-0b1.src.rpm): free
2592847 build (dist-5E-epel, php-jpgraph-3.5-0b1.src.rpm): free -> open (ppc04.phx2.fedoraproject.org)
  2592848 buildArch (php-jpgraph-3.5-0b1.src.rpm, noarch): open (ppc04.phx2.fedoraproject.org)
  2592848 buildArch (php-jpgraph-3.5-0b1.src.rpm, noarch): open (ppc04.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
2592847 build (dist-5E-epel, php-jpgraph-3.5-0b1.src.rpm): open (ppc04.phx2.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

2592847 build (dist-5E-epel, php-jpgraph-3.5-0b1.src.rpm) completed successfully

---

Thanks
Jeffrey-

Comment 1 Jeffrey Ness 2010-11-10 15:21:07 UTC

Correcting URLs

Spec URL: http://flip-edesign.com/source/php-jpgraph/php-jpgraph.spec
SRPM URL: http://flip-edesign.com/source/php-jpgraph/php-jpgraph-3.5.0b1-1.src.rpm
--

And a new rpmlint:

$ rpmlint SRPMS/php-jpgraph-3.5.0b1-1.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--

Jeffrey-

Comment 2 Terje Røsten 2010-11-10 19:42:15 UTC

- splitting is needed here, move 

 o docs/ to -doc subpackage and  

 o /src/Examples to -example subpackage
 
 o seems like src/barcode/ is a example (move to -example subpackage if that is the case)

 o then remove the src/  dir such that 
   /usr/share/php/php-jpgraph/src becomes /usr/share/php/php-jpgraph
   jpgraph-* files and friends lives in /usr/share/php/php-jpgraph

- remove the ttf fonts, and create symlinks to system ttf fonts

Comment 3 Remi Collet 2010-11-11 08:35:37 UTC

Additional notes:
- use a compressed archive (Source0)
- fix version/release according to the Guidelines for pre-release
  p.e. jpgraph-3.5.0-0.1.b1
- don't requires PHP (which pull apache), but required extensions, according to pci result :
  Requires: php-xml php-gd php-mbstring php-bcmath >= 5.0.0

Comment 4 Terje Røsten 2010-11-11 08:45:34 UTC

Some more
- use disttag in release
- source url must link to proper upstream location

Comment 5 Gianluca Sforna 2010-11-11 09:25:46 UTC

Uhm. last time I checked jpgraph was free only for non commercial use, which is not compatible with our licensing guidelines. See this past thread for more info:

http://thread.gmane.org/gmane.linux.redhat.fedora.devel/52306

That's also why Debian/Ubuntu includes an older version (the last one w/o this issue):

http://packages.debian.org/lenny/libphp-jpgraph
http://packages.ubuntu.com/natty/libphp-jpgraph

Comment 6 Jeffrey Ness 2010-11-11 20:05:44 UTC

Closing this bug out due to the license issue.