Bug 65198

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc2) Gecko/20020510

Description of problem:
The bug is in the part of the installation that updates the grub.conf file. When
converting an ext2 boot partition to ext3, it needs to add a an initrd line. But
it does not do that properly if the old grub.conf file had been customized by
hand and had a commented line originally.

Version-Release number of selected component (if applicable):


How reproducible:
Didn't try

Steps to Reproduce:
1) Configure a RH 7.2 system to use ext3 on the boot partition.

2) Edit the grub.conf file and add a commented copy of the kernel line right
below the original "kernel /boot/vmlinuz..." line

3) Do the RH7.3 upgrade and ask it to convert the boot partition to ext3

Actual Results:  It created a journal and updated the /etc/fstab. It even
created the appropriate /boot/initrd-2.4.18-3.img file. But it forgot a newline
or something when it updated the grub.conf file. It had the following:

title Red Hat Linux (2.4.18-3)
	root (hd0,2)
	kernel /boot/vmlinuz-2.4.18-3 ro root=/dev/hda3 hdc=ide-scsi 
# 	kernel /boot/vmlinuz-2.4.7-10 ro root=/dev/hda3 hdc=ide-scsiinitrd
/boot/initrd-2.4.18-3.img

As you can see, the initrd line was stuck on the end of the previously commented
out line rather than on a newline immediately following the new kernel line.

The result was the appearance that the conversion to ext3 had not taken place.

Expected Results:  It should have made sure that the initrd line started at the
beginning of the line.



Additional info: