Bug 652085
| Summary: | Review Request: SFML - A simple and fast multimedia library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | MERCIER Jonathan <bioinfornatics> |
| Component: | Package Review | Assignee: | Haïkel Guémar <karlthered> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 14 | CC: | belegdol, fedora-package-review, julian.fedora, karlthered, notting, tim, vytautas1987 |
| Target Milestone: | --- | Flags: | karlthered:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-18 23:29:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 997679 | ||
|
Description
MERCIER Jonathan
2010-11-10 23:31:09 UTC
Update Koji build : F13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2594890 F14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2594895 SPEC: http://bioinfornatics.fedorapeople.org/sfml.spec The summary should read simply "A simple and fast multimedia library" instead of "SFML is a simple and fast multimedia library" spec update * license field should use standard short name: zlib instead of zlib/libpng. * unversionned shared libraries should go into appropriate devel subpackage * no %post & %postun for shared libraries subpackages * incoherent versionning in changelog: use major.minor.revision scheme ! * main package group should be "Development/Libraries" * any reason not shipping sfml bindings ? at least, you should enable C, Python, Ruby and D ;) * what's the status of sfml 1.6 ? are the two branches parallel installable ? if it's the case, you should consider renaming your package sfml2. i can't enable sfml binding in same time for example for CSFML we need have FindSFML.cmake in /usr/share/cmake/Modules/FindSFML.cmake.
I do not know how said to cmake look this module in %{buildroot}/%{_datadir}/cmake/Modules/FindSFML.cmake
cmake search only in /usr/share/cmake/Modules.
SFML 1.6 is unmaintained
For other thing i will fix spec file
> cmake search only in /usr/share/cmake/Modules
You can override default search path by using variable CMAKE_MODULE_PATH, you may even reorder search path priorities. That's basic stuff for awesome build systems like CMake.
I see 2 options from there:
a) hacking CMake files to enable building bindings, do-able but requires some cmake wizardry.
b) regenerate your tarballs without bindings.
i'd rather go with option b) and ask SFML maintainer to provide proper sources tarballs when it goes stable. It will simplify both upstream and downstream maintainers lifes.
i choose b/ update rpm package scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2691167 * devel subpackages should require their non-devel counterpart. * since you use %cmake macro, you don't need to set CMAKE_INSTALL_PREFIX, CMAKE_INSTALL_LIBDIR or LIB_INSTALL_DIR (rpm --eval %cmake will tell which options are already enabled). You could probably drop the VERBOSE=1 as we set CMAKE_VERBOSE_MAKEFILE. * to improve spec readability, avoid lines longer than 80 columns or any reasonnable limit. F-15 requires some trivial fixes to build (NULL undefined, just replace with 0). Would you consider to go on with the review? sorry i have miss your message, currently i works on ldc 2 so i think is better wait ldc 2 (D2) is done and after continuing D packaging Any progress? I have made an SFML-1.6 package and submitted it for review. It is required by the dolphin emulator, which might be then targeted to RPM Fusion. *** This bug has been marked as a duplicate of bug 759059 *** |