Bug 652414

Summary: Review Request: rubygem-boxgrinder-build-sftp-delivery-plugin - BoxGrinder plugin delivering appliances to SFTP servers
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bos, fedora-package-review, gholms, notting
Target Milestone: ---Flags: mtasaka: fedora‑review+
tibbs: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-23 13:25:59 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On: 652400    
Bug Blocks:    

Description Marek Goldmann 2010-11-11 14:50:07 EST
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.3-2.fc14.src.rpm
Description:

BoxGrinder Build (http://www.jboss.org/boxgrinder) to
Fedora. BoxGrinder is a command line tool for building appliances (virtual
machines) to various platforms (KVM, Xen, VMware, EC2).

This package contains files required to deliver appliances to remote SFTP servers.
Comment 1 Marek Goldmann 2010-11-25 09:50:31 EST
Updated spec files:

Spec URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.3-3.fc15.src.rpm

Changelog:

* Tue Nov 23 2010  <mgoldman@redhat.com> - 0.0.3-3
- Cleaned Requires/Build Requires
- Added BR: rubygem(rake), BR: rubygem(echoe), BR: rubygem(rspec)
Comment 2 Marek Goldmann 2010-11-29 15:22:22 EST
Updated spec files:

Spec URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.4-1.fc15.src.rpm

Changelog:

* Mon Nov 29 2010  <mgoldman@redhat.com> - 0.0.4-1
- Upstream release: 0.0.4
- [BGBUILD-108] No plugin-manager require for sftp delivery plugin
Comment 3 Bryan O'Sullivan 2010-11-29 18:30:36 EST
Build errors:

	rubygem(net-sftp) is needed by rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.4-1.fc14.noarch
	rubygem(net-ssh) is needed by rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.4-1.fc14.noarch
	rubygem(progressbar) is needed by rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.4-1.fc14.noarch

Please run a build under mock before resubmitting :-)
Comment 4 Marek Goldmann 2010-11-30 03:07:30 EST
This package will be not available to build for F13/F14 for a week or two because its dependencies are not yet in stable for Fedora 13 and 14. Still waiting for rubygem-boxgrinder-core and rubygem-boxgrinder-build.

Btw, all gems you mentioned are already in stable:

https://admin.fedoraproject.org/updates/search/rubygem-net-ssh (rubygem-net-ssh-2.0.23-5)
https://admin.fedoraproject.org/updates/search/rubygem-net-sftp (rubygem-net-sftp-2.0.5-2)
https://admin.fedoraproject.org/updates/search/rubygem-progressbar (rubygem-progressbar-0.9.0-2)

Build log for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2633936
Comment 5 Marek Goldmann 2010-12-09 07:46:43 EST
Dependencies should be now in stable.
Comment 6 Marek Goldmann 2010-12-18 05:17:28 EST
Ping
Comment 7 Marek Goldmann 2011-01-12 13:12:34 EST
Ping again
Comment 8 Marek Goldmann 2011-01-17 11:26:47 EST
Updated spec files:

Spec URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc14.src.rpm

Changelog:

* Tue Dec 14 2010  <mgoldman@redhat.com> - 0.0.5-1
- Upstream release: 0.0.5
- [BGBUILD-115] PackageHelper should take directory instead of file list to package

Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2726173
Comment 9 Mamoru TASAKA 2011-01-20 07:42:18 EST
I will take a look at this.

By the way I would appreciate it if you would review
my review request (bug 669902)
Comment 10 Mamoru TASAKA 2011-01-21 13:17:41 EST
Well, nothing which must be fixed I see.

* source clean, match with the upstream
* spec file clean
* builds on koji
* rebuilt rpms can be installed
* basic operation (for gem related pkg) works

! One misc
  - "rm -rf %{buildroot}" at the beginning of %install is no
    longer needed.

------------------------------------------------------------------
    This package (rubygem-boxgrinder-build-sftp-delivery-plugin)
    is APPROVED by mtasaka
------------------------------------------------------------------
Comment 11 Marek Goldmann 2011-01-21 15:32:39 EST
Thank you for review!

New Package SCM Request
=======================
Package Name:      rubygem-boxgrinder-build-sftp-delivery-plugin
Short Description: BoxGrinder plugin delivering appliances to SFTP servers
Owners:            goldmann
Branches:          f13 f14
Comment 12 Jason Tibbitts 2011-01-21 17:14:29 EST
Git done (by process-git-requests).
Comment 13 Fedora Update System 2011-01-22 03:02:18 EST
rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc13
Comment 14 Fedora Update System 2011-01-22 03:02:26 EST
rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc14
Comment 15 Fedora Update System 2011-01-22 15:34:27 EST
rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-build-sftp-delivery-plugin'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc13
Comment 16 Mamoru TASAKA 2011-01-23 13:25:59 EST
Closing.
Comment 17 Marek Goldmann 2011-01-25 03:05:22 EST
Package Change Request
======================
Package Name: rubygem-boxgrinder-build-sftp-delivery-plugin
New Branches: el5 el6
Owners: goldmann
Comment 18 Jason Tibbitts 2011-01-25 09:09:29 EST
Git done (by process-git-requests).
Comment 19 Fedora Update System 2011-01-30 14:50:13 EST
rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2011-01-30 14:50:57 EST
rubygem-boxgrinder-build-sftp-delivery-plugin-0.0.5-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.